From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38E8E32ED29; Tue, 21 Oct 2025 11:44:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761047060; cv=none; b=qdygHhCNmlZ9t2VxrHzP0aZDq/F7QdGbvfqMlj+vLLW1dONBeMO8HIFIBf0HKIOtSIMGofj/bYjfVmkWQC48daND8aBgOqp6WyKvKo1SibRDoRPrnglMrY/wrRYnZ6V3Ay3z0qtQY5uMpxBl/VLM0BmhHo5IJ0sSvIEH18i27lQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761047060; c=relaxed/simple; bh=7aAHCcaecm2VZuosAD5WF6qVRIAZipjG6VYIR7g9o5A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Xc55GAYFKCCWXyat99QXO7VNqeSZKljaiYdbUjNfMG/x06i0nv86hk9mlYce4UM5+fyte4ftKl5MlAwvTG55koZpZfzxkFom50u6tyfuD8E2kuR0SmNPpGG0iVlmVpQmJ1Syq6pTDCW0g+1DoMZvZ44Ot/4Db9gvYcmrxYaRjZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y82yqj6d; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y82yqj6d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7091C4CEF5; Tue, 21 Oct 2025 11:44:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761047059; bh=7aAHCcaecm2VZuosAD5WF6qVRIAZipjG6VYIR7g9o5A=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Y82yqj6d9aBly9/d3JdzIsvZ0gC7WxocVs1pSzc5B/GM5xVF56sEokeSmJj9xWQ2f AxR+d1jTNJzBxPXzmn1HJdD3DqX+v6GAvmpBTJ0IFAdZ5Uuy19/F3e4t/HRMCKn8Jy OO7Xugn2N7KT2Sbt+nhZkUf9zCEhdelIovC3BFq9G5xWX3d6/sPpZht8ckhImLMk8P RZjgSGY5iSd+VuIuKdm8okcxlS5X0nWVn1aX/L83aaUBM9fCL9FKcdLyPgo5p7BKK9 tSaTtupbUk1K9AE3UnE2i77evyfTssEye54k71cSBCSSDShnSoBpxSFcqI685YAZUL 9Lw3M7QvtaOPA== From: Christian Brauner Date: Tue, 21 Oct 2025 13:43:12 +0200 Subject: [PATCH RFC DRAFT 06/50] nstree: simplify return Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251021-work-namespace-nstree-listns-v1-6-ad44261a8a5b@kernel.org> References: <20251021-work-namespace-nstree-listns-v1-0-ad44261a8a5b@kernel.org> In-Reply-To: <20251021-work-namespace-nstree-listns-v1-0-ad44261a8a5b@kernel.org> To: linux-fsdevel@vger.kernel.org, Josef Bacik , Jeff Layton Cc: Jann Horn , Mike Yuan , =?utf-8?q?Zbigniew_J=C4=99drzejewski-Szmek?= , Lennart Poettering , Daan De Meyer , Aleksa Sarai , Amir Goldstein , Tejun Heo , Johannes Weiner , Thomas Gleixner , Alexander Viro , Jan Kara , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, bpf@vger.kernel.org, Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org, Arnd Bergmann , Christian Brauner X-Mailer: b4 0.15-dev-96507 X-Developer-Signature: v=1; a=openpgp-sha256; l=670; i=brauner@kernel.org; h=from:subject:message-id; bh=7aAHCcaecm2VZuosAD5WF6qVRIAZipjG6VYIR7g9o5A=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWR8L3zTULyoJv2x89unobEd/j3drZbrtjPPXH8kfd6Gl PTt1bldHaUsDGJcDLJiiiwO7Sbhcst5KjYbZWrAzGFlAhnCwMUpABN5s52R4XtpqM/CrDD72Zt+ bgrk0fBaedC94AL3x1NcFw8/XB5dtYzhFzPntGUGkvlv96143jS58QpvataUZpHHi+Mn2Xo82s3 oyg4A X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 node_to_ns() checks for NULL and the assert isn't really helpful and will have to be dropped later anyway. Signed-off-by: Christian Brauner --- kernel/nstree.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/kernel/nstree.c b/kernel/nstree.c index b24a320a11a6..369fd1675c6a 100644 --- a/kernel/nstree.c +++ b/kernel/nstree.c @@ -194,11 +194,6 @@ struct ns_common *ns_tree_lookup_rcu(u64 ns_id, int ns_type) break; } while (read_seqretry(&ns_tree->ns_tree_lock, seq)); - if (!node) - return NULL; - - VFS_WARN_ON_ONCE(node_to_ns(node)->ns_type != ns_type); - return node_to_ns(node); } -- 2.47.3