cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: linux-fsdevel@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>,
	 Jeff Layton <jlayton@kernel.org>
Cc: "Jann Horn" <jannh@google.com>, "Mike Yuan" <me@yhndnzj.com>,
	"Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
	"Lennart Poettering" <mzxreary@0pointer.de>,
	"Daan De Meyer" <daan.j.demeyer@gmail.com>,
	"Aleksa Sarai" <cyphar@cyphar.com>,
	"Amir Goldstein" <amir73il@gmail.com>,
	"Tejun Heo" <tj@kernel.org>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Jan Kara" <jack@suse.cz>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	bpf@vger.kernel.org, "Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	netdev@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
	"Christian Brauner" <brauner@kernel.org>
Subject: [PATCH v2 02/63] nsfs: use inode_just_drop()
Date: Wed, 22 Oct 2025 18:05:40 +0200	[thread overview]
Message-ID: <20251022-work-namespace-nstree-listns-v2-2-71a588572371@kernel.org> (raw)
In-Reply-To: <20251022-work-namespace-nstree-listns-v2-0-71a588572371@kernel.org>

Currently nsfs uses the default inode_generic_drop() fallback which
drops the inode when it's unlinked or when it's unhashed. Since nsfs
never hashes inodes that always amounts to dropping the inode.

But that's just annoying to have to reason through every time we look at
this code. Switch to inode_just_drop() which always drops the inode
explicitly. This also aligns the behavior with pidfs which does the
same.

Signed-off-by: Christian Brauner <brauner@kernel.org>
---
 fs/nsfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/nsfs.c b/fs/nsfs.c
index 648dc59bef7f..4e77eba0c8fc 100644
--- a/fs/nsfs.c
+++ b/fs/nsfs.c
@@ -408,6 +408,7 @@ static const struct super_operations nsfs_ops = {
 	.statfs = simple_statfs,
 	.evict_inode = nsfs_evict,
 	.show_path = nsfs_show_path,
+	.drop_inode = inode_just_drop,
 };
 
 static int nsfs_init_inode(struct inode *inode, void *data)

-- 
2.47.3


  parent reply	other threads:[~2025-10-22 16:06 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22 16:05 [PATCH v2 00/63] nstree: listns() Christian Brauner
2025-10-22 16:05 ` [PATCH v2 01/63] libfs: allow to specify s_d_flags Christian Brauner
2025-10-22 16:05 ` Christian Brauner [this message]
2025-10-22 16:05 ` [PATCH v2 03/63] nsfs: raise DCACHE_DONTCACHE explicitly Christian Brauner
2025-10-22 16:05 ` [PATCH v2 04/63] pidfs: " Christian Brauner
2025-10-22 16:05 ` [PATCH v2 05/63] nsfs: raise SB_I_NODEV and SB_I_NOEXEC Christian Brauner
2025-10-22 16:05 ` [PATCH v2 06/63] cgroup: add cgroup namespace to tree after owner is set Christian Brauner
2025-10-22 16:05 ` [PATCH v2 07/63] nstree: simplify return Christian Brauner
2025-10-22 16:05 ` [PATCH v2 08/63] ns: initialize ns_list_node for initial namespaces Christian Brauner
2025-10-22 16:05 ` [PATCH v2 09/63] ns: add __ns_ref_read() Christian Brauner
2025-10-22 16:05 ` [PATCH v2 10/63] ns: add active reference count Christian Brauner
2025-10-23  7:29   ` kernel test robot
2025-10-22 16:05 ` [PATCH v2 11/63] ns: use anonymous struct to group list member Christian Brauner
2025-10-22 16:05 ` [PATCH v2 12/63] nstree: introduce a unified tree Christian Brauner
2025-10-22 16:05 ` [PATCH v2 13/63] nstree: allow lookup solely based on inode Christian Brauner
2025-10-22 16:05 ` [PATCH v2 14/63] nstree: assign fixed ids to the initial namespaces Christian Brauner
2025-10-22 16:05 ` [PATCH v2 15/63] ns: maintain list of owned namespaces Christian Brauner
2025-10-22 16:05 ` [PATCH v2 16/63] nstree: add listns() Christian Brauner
2025-10-22 16:05 ` [PATCH v2 17/63] arch: hookup listns() system call Christian Brauner
2025-10-22 16:05 ` [PATCH v2 18/63] nsfs: update tools header Christian Brauner
2025-10-22 16:05 ` [PATCH v2 19/63] selftests/filesystems: remove CLONE_NEWPIDNS from setup_userns() helper Christian Brauner
2025-10-22 16:05 ` [PATCH v2 20/63] selftests/namespaces: first active reference count tests Christian Brauner
2025-10-22 16:05 ` [PATCH v2 21/63] selftests/namespaces: second " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 22/63] selftests/namespaces: third " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 23/63] selftests/namespaces: fourth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 24/63] selftests/namespaces: fifth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 25/63] selftests/namespaces: sixth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 26/63] selftests/namespaces: seventh " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 27/63] selftests/namespaces: eigth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 28/63] selftests/namespaces: ninth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 29/63] selftests/namespaces: tenth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 30/63] selftests/namespaces: eleventh " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 31/63] selftests/namespaces: twelth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 32/63] selftests/namespaces: thirteenth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 33/63] selftests/namespaces: fourteenth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 34/63] selftests/namespaces: fifteenth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 35/63] selftests/namespaces: add listns() wrapper Christian Brauner
2025-10-22 16:06 ` [PATCH v2 36/63] selftests/namespaces: first listns() test Christian Brauner
2025-10-22 16:06 ` [PATCH v2 37/63] selftests/namespaces: second " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 38/63] selftests/namespaces: third " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 39/63] selftests/namespaces: fourth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 40/63] selftests/namespaces: fifth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 41/63] selftests/namespaces: sixth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 42/63] selftests/namespaces: seventh " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 43/63] selftests/namespaces: ninth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 44/63] " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 45/63] selftests/namespaces: first listns() permission test Christian Brauner
2025-10-22 16:06 ` [PATCH v2 46/63] selftests/namespaces: second " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 47/63] selftests/namespaces: third " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 48/63] selftests/namespaces: fourth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 49/63] selftests/namespaces: fifth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 50/63] selftests/namespaces: sixth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 51/63] selftests/namespaces: seventh " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 52/63] selftests/namespaces: first inactive namespace resurrection test Christian Brauner
2025-10-22 16:06 ` [PATCH v2 53/63] selftests/namespaces: second " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 54/63] selftests/namespaces: third " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 55/63] selftests/namespaces: fourth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 56/63] selftests/namespaces: fifth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 57/63] selftests/namespaces: sixth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 58/63] selftests/namespaces: seventh " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 59/63] selftests/namespaces: eigth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 60/63] selftests/namespaces: ninth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 61/63] selftests/namespaces: tenth " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 62/63] selftests/namespaces: eleventh " Christian Brauner
2025-10-22 16:06 ` [PATCH v2 63/63] selftests/namespaces: twelth " Christian Brauner
2025-10-22 19:16 ` [syzbot ci] Re: nstree: listns() syzbot ci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251022-work-namespace-nstree-listns-v2-2-71a588572371@kernel.org \
    --to=brauner@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bpf@vger.kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=cyphar@cyphar.com \
    --cc=daan.j.demeyer@gmail.com \
    --cc=edumazet@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=jannh@google.com \
    --cc=jlayton@kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=kuba@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@yhndnzj.com \
    --cc=mzxreary@0pointer.de \
    --cc=netdev@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zbyszek@in.waw.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).