From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F2D929993A; Wed, 22 Oct 2025 16:06:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761149197; cv=none; b=LoejxZ/BBb3TiqZEjyUywdQ1wzaXGFvonAbjhTbHZdEadCNuDWsuebowlqWUV6xGaN9kC1MEGZV3wb8bhqGZAZr5vZqj3uaTqIS3mOtFsvepB3O7qOH/GDPMsjqHZG7IBB+2capdmShxZ8OiJxMp9Phyx4XNaT5TCXBZfNF9QME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761149197; c=relaxed/simple; bh=74AZcYyOqxtykIDy/RGdL2vrgfuHMaAEm8WcGrCjYG4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nowQFhRTyPfsE0oz/zCXpUxQ4R9w4EwJfprXUuuLqaRED8KW027Gdcg2DLucUTUNcmgCI/5QjQywK2pYX7mte6QJDmdIlOJ3aZUcylhHJZVnrsd9JX2bb6EAF+jv+r9t6MGFOnWXpI+S+zdOeY8ChDzPrNLvrnZ0qVwRXHwb/D8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GsorfsuM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GsorfsuM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56A08C4CEF7; Wed, 22 Oct 2025 16:06:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761149197; bh=74AZcYyOqxtykIDy/RGdL2vrgfuHMaAEm8WcGrCjYG4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=GsorfsuMaDIbFLNgdihZm04ueS3KjYr/ga6yYj4Zfg24+ohkDKwX86q+33D1/Vuvb aoccV/kAOgePvPxCn70d5jg3agm1COKNt+uhWnLVuthdG9tNKa4jNv67AMq/Wcn3LK MlVQaKArHievEQkGdNGEjUithrWeAtY9C5mmQ/uBaWRJ9PHYlM5ECSGwZ0/1FcBiBW yK8IOTbrUkZQiG3zg9kz9+/lcvtCdiQI4eU0e82Hg/PNciWjIGLEXottZfdN15HOYf MsEEi1kXM7+hkQKxccs0dlkUcXwXQfGul3DOAJ5zFBbGq7j3U9MXuquh4jwUcgVvFZ 3MN3Hi+V5AGJA== From: Christian Brauner Date: Wed, 22 Oct 2025 18:05:44 +0200 Subject: [PATCH v2 06/63] cgroup: add cgroup namespace to tree after owner is set Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251022-work-namespace-nstree-listns-v2-6-71a588572371@kernel.org> References: <20251022-work-namespace-nstree-listns-v2-0-71a588572371@kernel.org> In-Reply-To: <20251022-work-namespace-nstree-listns-v2-0-71a588572371@kernel.org> To: linux-fsdevel@vger.kernel.org, Josef Bacik , Jeff Layton Cc: Jann Horn , Mike Yuan , =?utf-8?q?Zbigniew_J=C4=99drzejewski-Szmek?= , Lennart Poettering , Daan De Meyer , Aleksa Sarai , Amir Goldstein , Tejun Heo , Johannes Weiner , Thomas Gleixner , Alexander Viro , Jan Kara , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, bpf@vger.kernel.org, Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org, Arnd Bergmann , Christian Brauner X-Mailer: b4 0.15-dev-96507 X-Developer-Signature: v=1; a=openpgp-sha256; l=835; i=brauner@kernel.org; h=from:subject:message-id; bh=74AZcYyOqxtykIDy/RGdL2vrgfuHMaAEm8WcGrCjYG4=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWT8ZHjyPsfJZhGzwsvKjjj1BbqCWzuf7Clg3mV96bj9Z iV1KZYrHaUsDGJcDLJiiiwO7Sbhcst5KjYbZWrAzGFlAhnCwMUpABPx8GT4X55lvP7WLFt5jz3i Lr/ett9ZXbPyu6zKOSnV24VC+2fzP2NkmG/xJ+31w8QYzTkBj9ku7PLxEVvkUa0X3TrnwvLyNVy tTAA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Otherwise we trip VFS_WARN_ON_ONC() in __ns_tree_add_raw(). Fixes: 7c6059398533 ("cgroup: support ns lookup") Signed-off-by: Christian Brauner --- kernel/cgroup/namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/cgroup/namespace.c b/kernel/cgroup/namespace.c index fdbe57578e68..db9617556dd7 100644 --- a/kernel/cgroup/namespace.c +++ b/kernel/cgroup/namespace.c @@ -30,7 +30,6 @@ static struct cgroup_namespace *alloc_cgroup_ns(void) ret = ns_common_init(new_ns); if (ret) return ERR_PTR(ret); - ns_tree_add(new_ns); return no_free_ptr(new_ns); } @@ -86,6 +85,7 @@ struct cgroup_namespace *copy_cgroup_ns(u64 flags, new_ns->ucounts = ucounts; new_ns->root_cset = cset; + ns_tree_add(new_ns); return new_ns; } -- 2.47.3