cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: linux-fsdevel@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>,
	 Jeff Layton <jlayton@kernel.org>
Cc: "Jann Horn" <jannh@google.com>, "Mike Yuan" <me@yhndnzj.com>,
	"Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
	"Lennart Poettering" <mzxreary@0pointer.de>,
	"Daan De Meyer" <daan.j.demeyer@gmail.com>,
	"Aleksa Sarai" <cyphar@cyphar.com>,
	"Amir Goldstein" <amir73il@gmail.com>,
	"Tejun Heo" <tj@kernel.org>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Jan Kara" <jack@suse.cz>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	bpf@vger.kernel.org, "Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	netdev@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
	"Christian Brauner" <brauner@kernel.org>
Subject: [PATCH v3 30/70] selftests/namespaces: tenth active reference count tests
Date: Fri, 24 Oct 2025 12:52:59 +0200	[thread overview]
Message-ID: <20251024-work-namespace-nstree-listns-v3-30-b6241981b72b@kernel.org> (raw)
In-Reply-To: <20251024-work-namespace-nstree-listns-v3-0-b6241981b72b@kernel.org>

Test multiple children sharing same parent.
Parent should stay active as long as ANY child is active.

Signed-off-by: Christian Brauner <brauner@kernel.org>
---
 .../selftests/namespaces/ns_active_ref_test.c      | 170 +++++++++++++++++++++
 1 file changed, 170 insertions(+)

diff --git a/tools/testing/selftests/namespaces/ns_active_ref_test.c b/tools/testing/selftests/namespaces/ns_active_ref_test.c
index 88189398aa35..a334792da982 100644
--- a/tools/testing/selftests/namespaces/ns_active_ref_test.c
+++ b/tools/testing/selftests/namespaces/ns_active_ref_test.c
@@ -1106,4 +1106,174 @@ TEST(ns_multilevel_hierarchy)
 	close(gp_fd);
 }
 
+/*
+ * Test multiple children sharing same parent.
+ * Parent should stay active as long as ANY child is active.
+ */
+TEST(ns_multiple_children_same_parent)
+{
+	struct file_handle *p_handle, *c1_handle, *c2_handle;
+	int ret, pipefd[2];
+	pid_t pid;
+	int status;
+	__u64 p_id, c1_id, c2_id;
+	char p_buf[sizeof(*p_handle) + MAX_HANDLE_SZ];
+	char c1_buf[sizeof(*c1_handle) + MAX_HANDLE_SZ];
+	char c2_buf[sizeof(*c2_handle) + MAX_HANDLE_SZ];
+
+	ASSERT_EQ(pipe(pipefd), 0);
+	pid = fork();
+	ASSERT_GE(pid, 0);
+
+	if (pid == 0) {
+		close(pipefd[0]);
+
+		/* Create parent user namespace */
+		if (setup_userns() < 0) {
+			close(pipefd[1]);
+			exit(1);
+		}
+
+		int p_fd = open("/proc/self/ns/user", O_RDONLY);
+		if (p_fd < 0) {
+			close(pipefd[1]);
+			exit(1);
+		}
+		if (ioctl(p_fd, NS_GET_ID, &p_id) < 0) {
+			close(p_fd);
+			close(pipefd[1]);
+			exit(1);
+		}
+		close(p_fd);
+
+		/* Create first child user namespace */
+		if (setup_userns() < 0) {
+			close(pipefd[1]);
+			exit(1);
+		}
+
+		int c1_fd = open("/proc/self/ns/user", O_RDONLY);
+		if (c1_fd < 0) {
+			close(pipefd[1]);
+			exit(1);
+		}
+		if (ioctl(c1_fd, NS_GET_ID, &c1_id) < 0) {
+			close(c1_fd);
+			close(pipefd[1]);
+			exit(1);
+		}
+		close(c1_fd);
+
+		/* Return to parent user namespace and create second child */
+		/* We can't actually do this easily, so let's create a sibling namespace
+		 * by creating a network namespace instead */
+		if (unshare(CLONE_NEWNET) < 0) {
+			close(pipefd[1]);
+			exit(1);
+		}
+
+		int c2_fd = open("/proc/self/ns/net", O_RDONLY);
+		if (c2_fd < 0) {
+			close(pipefd[1]);
+			exit(1);
+		}
+		if (ioctl(c2_fd, NS_GET_ID, &c2_id) < 0) {
+			close(c2_fd);
+			close(pipefd[1]);
+			exit(1);
+		}
+		close(c2_fd);
+
+		/* Send all namespace IDs */
+		write(pipefd[1], &p_id, sizeof(p_id));
+		write(pipefd[1], &c1_id, sizeof(c1_id));
+		write(pipefd[1], &c2_id, sizeof(c2_id));
+		close(pipefd[1]);
+		exit(0);
+	}
+
+	close(pipefd[1]);
+
+	/* Read all three namespace IDs - fixed size, no parsing needed */
+	ret = read(pipefd[0], &p_id, sizeof(p_id));
+	if (ret != sizeof(p_id)) {
+		close(pipefd[0]);
+		waitpid(pid, NULL, 0);
+		SKIP(return, "Failed to read parent namespace ID");
+	}
+
+	ret = read(pipefd[0], &c1_id, sizeof(c1_id));
+	if (ret != sizeof(c1_id)) {
+		close(pipefd[0]);
+		waitpid(pid, NULL, 0);
+		SKIP(return, "Failed to read first child namespace ID");
+	}
+
+	ret = read(pipefd[0], &c2_id, sizeof(c2_id));
+	close(pipefd[0]);
+	if (ret != sizeof(c2_id)) {
+		waitpid(pid, NULL, 0);
+		SKIP(return, "Failed to read second child namespace ID");
+	}
+
+	/* Construct file handles from namespace IDs */
+	p_handle = (struct file_handle *)p_buf;
+	p_handle->handle_bytes = sizeof(struct nsfs_file_handle);
+	p_handle->handle_type = FILEID_NSFS;
+	struct nsfs_file_handle *p_fh = (struct nsfs_file_handle *)p_handle->f_handle;
+	p_fh->ns_id = p_id;
+	p_fh->ns_type = 0;
+	p_fh->ns_inum = 0;
+
+	c1_handle = (struct file_handle *)c1_buf;
+	c1_handle->handle_bytes = sizeof(struct nsfs_file_handle);
+	c1_handle->handle_type = FILEID_NSFS;
+	struct nsfs_file_handle *c1_fh = (struct nsfs_file_handle *)c1_handle->f_handle;
+	c1_fh->ns_id = c1_id;
+	c1_fh->ns_type = 0;
+	c1_fh->ns_inum = 0;
+
+	c2_handle = (struct file_handle *)c2_buf;
+	c2_handle->handle_bytes = sizeof(struct nsfs_file_handle);
+	c2_handle->handle_type = FILEID_NSFS;
+	struct nsfs_file_handle *c2_fh = (struct nsfs_file_handle *)c2_handle->f_handle;
+	c2_fh->ns_id = c2_id;
+	c2_fh->ns_type = 0;
+	c2_fh->ns_inum = 0;
+
+	/* Open both children before process exits */
+	int c1_fd = open_by_handle_at(FD_NSFS_ROOT, c1_handle, O_RDONLY);
+	int c2_fd = open_by_handle_at(FD_NSFS_ROOT, c2_handle, O_RDONLY);
+
+	if (c1_fd < 0 || c2_fd < 0) {
+		if (c1_fd >= 0) close(c1_fd);
+		if (c2_fd >= 0) close(c2_fd);
+		waitpid(pid, NULL, 0);
+		SKIP(return, "Failed to open child namespaces");
+	}
+
+	waitpid(pid, &status, 0);
+	ASSERT_TRUE(WIFEXITED(status));
+	ASSERT_EQ(WEXITSTATUS(status), 0);
+
+	/* Parent should be active (both children active) */
+	TH_LOG("Both children active - parent should be active");
+	int p_fd = open_by_handle_at(FD_NSFS_ROOT, p_handle, O_RDONLY);
+	ASSERT_GE(p_fd, 0);
+	close(p_fd);
+
+	/* Close first child - parent should STILL be active */
+	TH_LOG("Closing first child - parent should still be active");
+	close(c1_fd);
+	p_fd = open_by_handle_at(FD_NSFS_ROOT, p_handle, O_RDONLY);
+	ASSERT_GE(p_fd, 0);
+	close(p_fd);
+
+	/* Close second child - NOW parent should become inactive */
+	TH_LOG("Closing second child - parent should become inactive");
+	close(c2_fd);
+	p_fd = open_by_handle_at(FD_NSFS_ROOT, p_handle, O_RDONLY);
+	ASSERT_LT(p_fd, 0);
+}
+
 TEST_HARNESS_MAIN

-- 
2.47.3


  parent reply	other threads:[~2025-10-24 10:55 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24 10:52 [PATCH v3 00/70] nstree: listns() Christian Brauner
2025-10-24 10:52 ` [PATCH v3 01/70] libfs: allow to specify s_d_flags Christian Brauner
2025-10-24 10:52 ` [PATCH v3 02/70] nsfs: use inode_just_drop() Christian Brauner
2025-10-24 10:52 ` [PATCH v3 03/70] nsfs: raise DCACHE_DONTCACHE explicitly Christian Brauner
2025-10-24 10:52 ` [PATCH v3 04/70] pidfs: " Christian Brauner
2025-10-24 10:52 ` [PATCH v3 05/70] nsfs: raise SB_I_NODEV and SB_I_NOEXEC Christian Brauner
2025-10-27 13:13   ` Jeff Layton
2025-10-24 10:52 ` [PATCH v3 06/70] cgroup: add cgroup namespace to tree after owner is set Christian Brauner
2025-10-24 10:52 ` [PATCH v3 07/70] nstree: simplify return Christian Brauner
2025-10-24 10:52 ` [PATCH v3 08/70] ns: initialize ns_list_node for initial namespaces Christian Brauner
2025-10-24 10:52 ` [PATCH v3 09/70] ns: add __ns_ref_read() Christian Brauner
2025-10-24 10:52 ` [PATCH v3 10/70] ns: rename to exit_nsproxy_namespaces() Christian Brauner
2025-10-24 10:52 ` [PATCH v3 11/70] ns: add active reference count Christian Brauner
2025-10-27 16:36   ` Thomas Gleixner
2025-10-28 10:30   ` Simon Horman
2025-10-24 10:52 ` [PATCH v3 12/70] ns: use anonymous struct to group list member Christian Brauner
2025-10-24 10:52 ` [PATCH v3 13/70] nstree: introduce a unified tree Christian Brauner
2025-10-24 10:52 ` [PATCH v3 14/70] nstree: allow lookup solely based on inode Christian Brauner
2025-10-27 13:48   ` Jeff Layton
2025-10-24 10:52 ` [PATCH v3 15/70] nstree: assign fixed ids to the initial namespaces Christian Brauner
2025-10-24 10:52 ` [PATCH v3 16/70] ns: maintain list of owned namespaces Christian Brauner
2025-10-24 10:52 ` [PATCH v3 17/70] nstree: add listns() Christian Brauner
2025-10-24 14:06   ` Arnd Bergmann
2025-10-27 14:04   ` Jeff Layton
2025-10-28 10:36   ` Simon Horman
2025-10-24 10:52 ` [PATCH v3 18/70] arch: hookup listns() system call Christian Brauner
2025-10-24 14:08   ` Arnd Bergmann
2025-10-24 10:52 ` [PATCH v3 19/70] nsfs: update tools header Christian Brauner
2025-10-24 10:52 ` [PATCH v3 20/70] selftests/filesystems: remove CLONE_NEWPIDNS from setup_userns() helper Christian Brauner
2025-10-24 10:52 ` [PATCH v3 21/70] selftests/namespaces: first active reference count tests Christian Brauner
2025-10-24 10:52 ` [PATCH v3 22/70] selftests/namespaces: second " Christian Brauner
2025-10-24 10:52 ` [PATCH v3 23/70] selftests/namespaces: third " Christian Brauner
2025-10-24 10:52 ` [PATCH v3 24/70] selftests/namespaces: fourth " Christian Brauner
2025-10-24 10:52 ` [PATCH v3 25/70] selftests/namespaces: fifth " Christian Brauner
2025-10-24 10:52 ` [PATCH v3 26/70] selftests/namespaces: sixth " Christian Brauner
2025-10-24 10:52 ` [PATCH v3 27/70] selftests/namespaces: seventh " Christian Brauner
2025-10-24 10:52 ` [PATCH v3 28/70] selftests/namespaces: eigth " Christian Brauner
2025-10-24 10:52 ` [PATCH v3 29/70] selftests/namespaces: ninth " Christian Brauner
2025-10-24 10:52 ` Christian Brauner [this message]
2025-10-24 10:53 ` [PATCH v3 31/70] selftests/namespaces: eleventh " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 32/70] selftests/namespaces: twelth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 33/70] selftests/namespaces: thirteenth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 34/70] selftests/namespaces: fourteenth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 35/70] selftests/namespaces: fifteenth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 36/70] selftests/namespaces: add listns() wrapper Christian Brauner
2025-10-24 10:53 ` [PATCH v3 37/70] selftests/namespaces: first listns() test Christian Brauner
2025-10-24 10:53 ` [PATCH v3 38/70] selftests/namespaces: second " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 39/70] selftests/namespaces: third " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 40/70] selftests/namespaces: fourth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 41/70] selftests/namespaces: fifth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 42/70] selftests/namespaces: sixth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 43/70] selftests/namespaces: seventh " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 44/70] selftests/namespaces: eigth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 45/70] selftests/namespaces: ninth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 46/70] selftests/namespaces: first listns() permission test Christian Brauner
2025-10-24 10:53 ` [PATCH v3 47/70] selftests/namespaces: second " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 48/70] selftests/namespaces: third " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 49/70] selftests/namespaces: fourth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 50/70] selftests/namespaces: fifth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 51/70] selftests/namespaces: sixth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 52/70] selftests/namespaces: seventh " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 53/70] selftests/namespaces: first inactive namespace resurrection test Christian Brauner
2025-10-24 10:53 ` [PATCH v3 54/70] selftests/namespaces: second " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 55/70] selftests/namespaces: third " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 56/70] selftests/namespaces: fourth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 57/70] selftests/namespaces: fifth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 58/70] selftests/namespaces: sixth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 59/70] selftests/namespaces: seventh " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 60/70] selftests/namespaces: eigth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 61/70] selftests/namespaces: ninth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 62/70] selftests/namespaces: tenth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 63/70] selftests/namespaces: eleventh " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 64/70] selftests/namespaces: twelth " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 65/70] selftests/namespace: first threaded active reference count test Christian Brauner
2025-10-24 10:53 ` [PATCH v3 66/70] selftests/namespace: second " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 67/70] selftests/namespace: third " Christian Brauner
2025-10-24 10:53 ` [PATCH v3 68/70] selftests/namespace: commit_creds() active reference tests Christian Brauner
2025-10-24 10:53 ` [PATCH v3 69/70] selftests/namespace: add stress test Christian Brauner
2025-10-24 10:53 ` [PATCH v3 70/70] selftests/namespace: test listns() pagination Christian Brauner
2025-10-27 14:10 ` [PATCH v3 00/70] nstree: listns() Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251024-work-namespace-nstree-listns-v3-30-b6241981b72b@kernel.org \
    --to=brauner@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bpf@vger.kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=cyphar@cyphar.com \
    --cc=daan.j.demeyer@gmail.com \
    --cc=edumazet@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=jannh@google.com \
    --cc=jlayton@kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=kuba@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@yhndnzj.com \
    --cc=mzxreary@0pointer.de \
    --cc=netdev@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zbyszek@in.waw.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).