From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50A5439903B for ; Mon, 9 Mar 2026 11:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773055818; cv=none; b=LquFXaCn6YRAX6/jJBtZuUJ+iQVkvO6GexinU5JNELgtGu+uWSb2tGRxJtCpWdQWT5WW+WaMXqeLcQ/H8LoAyXpT0RsRwr6HGPlZR52yhBsA+KrndqCtXAS2KO6ge9z1OTLTfNTT60ketsD9qWlKsUTundH654AoJuUsxOWIdI0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773055818; c=relaxed/simple; bh=kVbrYMP5pt1BQk2q3WW9YiMA91YhgZOOKnk1hZLVEjU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qucxrMxYpcXr5C02xF+a2Rfv/ZA94yjBlFmo4e94MIzyocUAr337ADDwBVPn295wXCKCqf4ZANVEKFUoQ1DeGnokzLiXLhuumRnLeKO1fJj3hNTyBPiPuGH2dG/kMBD40he8Xz7LKuu0Jt1nIYz4Xsxt5pN+eLIpy9rp0kw6zoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=teo9Eycf; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="teo9Eycf" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1773055803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BCaKEuNZgtMKShDR3GzW8YFYwaQK2TRr8wn9CI/U184=; b=teo9EycfvI/jhpEj3RqyVtnm67r8unNsx/x/W6sU0U+5DxrYxlRVWVXcfdIK5UpqvEzqSR rsU+bf0CAqnjsmuJYC6HA23y9MmFckwX6Une3zy2xCKal49LYSTFKvhweFYx6T9us3UrM8 mL6NmLE9it1YnGI94fPEW+KU/OcDIRI= From: Qi Zheng To: hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, bhe@redhat.com, usamaarif642@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Qi Zheng , Usama Arif Subject: [PATCH] fix: mm: memcontrol: convert objcg to be per-memcg per-node type Date: Mon, 9 Mar 2026 19:29:39 +0800 Message-ID: <20260309112939.31937-1-qi.zheng@linux.dev> In-Reply-To: <56c04b1c5d54f75ccdc12896df6c1ca35403ecc3.1772711148.git.zhengqi.arch@bytedance.com> References: <56c04b1c5d54f75ccdc12896df6c1ca35403ecc3.1772711148.git.zhengqi.arch@bytedance.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: Qi Zheng Reset pn->orig_objcg to NULL to prevent obj_cgroup_put() from being called agagin in __mem_cgroup_free(). Reported-by: Usama Arif Signed-off-by: Qi Zheng --- mm/memcontrol.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 992a3f5caa62b..ad32639ea5959 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4140,8 +4140,14 @@ static int mem_cgroup_css_online(struct cgroup_subsys_state *css) for_each_node(nid) { struct mem_cgroup_per_node *pn = memcg->nodeinfo[nid]; - if (pn && pn->orig_objcg) + if (pn && pn->orig_objcg) { obj_cgroup_put(pn->orig_objcg); + /* + * Reset pn->orig_objcg to NULL to prevent obj_cgroup_put() + * from being called agagin in __mem_cgroup_free(). + */ + pn->orig_objcg = NULL; + } } free_shrinker_info(memcg); offline_kmem: -- 2.20.1