From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4865A23D7FF for ; Wed, 6 May 2026 13:11:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778073114; cv=none; b=HxwRPQXau8QbT18k2F6SawnGjrDveCyJ3SU2rF7LoOse6F/hlRAofZ+96nKXjXodlF4lcM6u9YLTfML52kzouUGGqO0bv5TutCdV0JZ47Dx/U2UqPWrXLqxZPF/p7N4GKayMwOib/mDN/7JQ5EpmJVQUy4LIbm10Jfqli0JTIYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778073114; c=relaxed/simple; bh=7oPNT/4drhlEAKmSfGAYjPW0DZQ8O2lAShJdYAQVuSc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NrO1rumVPAQCcgSvxQLP5hcrsMuOOxM7UBx6mi9uRxSV9wMmsDjgG3e8KZ3DkapUolsrYQhgsQsGqNCxEC75/sGnMpqAIUKt6O+3TC/OLvO1bTfEfdfDOqwxiC7OSol0mKL/yBSTMjxnl63tWVWQr38OjBuxa8+dVt2A0bAImrA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 222f2fe6494d11f1aa26b74ffac11d73-20260506 X-CTIC-Tags: HR_CC_AS_FROM, HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED, SA_EXISTED SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS, CIE_GOOD CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO, GTI_C_BU, AMN_GOOD ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:58b5d4b2-9442-49e1-ba0b-a3954fa84b09,IP:10, URL:0,TC:0,Content:0,EDM:-20,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:-15 X-CID-INFO: VERSION:1.3.12,REQID:58b5d4b2-9442-49e1-ba0b-a3954fa84b09,IP:10,UR L:0,TC:0,Content:0,EDM:-20,RT:0,SF:-5,FILE:0,BULK:0,RULE:EDM_GE969F26,ACTI ON:release,TS:-15 X-CID-META: VersionHash:e7bac3a,CLOUDID:5beb23ae4de614d89a7812347d371d3f,BulkI D:260506211148O55B8KL0,BulkQuantity:0,Recheck:0,SF:17|19|38|66|78|102|127| 898,TC:nil,Content:0|15|50,EDM:1,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:n il,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC :0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_AEC,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 222f2fe6494d11f1aa26b74ffac11d73-20260506 X-User: cuitao@kylinos.cn Received: from ctao-book.. [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1118350624; Wed, 06 May 2026 21:11:46 +0800 From: Tao Cui To: tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org Cc: Tao Cui Subject: [PATCH] blk-cgroup: fix blkg->online set on radix_tree_insert failure Date: Wed, 6 May 2026 21:11:24 +0800 Message-ID: <20260506131124.16755-1-cuitao@kylinos.cn> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In blkg_create(), blkg->online was set to true unconditionally outside the radix_tree_insert success check. When the insertion fails, the blkg is not in the radix tree nor the hash/list, yet it is incorrectly marked online. This state inconsistency could cause future code paths that depend on blkg->online to behave incorrectly. Move blkg->online = true inside the if (likely(!ret)) block so that it is only set when the blkg is fully initialized and inserted. Signed-off-by: Tao Cui --- block/blk-cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 554c87bb4a86..539301f4f645 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -431,8 +431,8 @@ static struct blkcg_gq *blkg_create(struct blkcg *blkcg, struct gendisk *disk, blkg->pd[i]->online = true; } } + blkg->online = true; } - blkg->online = true; spin_unlock(&blkcg->lock); if (!ret) -- 2.43.0