From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 936CB33F589; Mon, 15 Jun 2026 11:54:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781524493; cv=none; b=RnHAJdWmEFOxATuWNIZKQvjTe33ydxQUYTI//yxvLGGQ9n7LXgdR6FPcOxanq9R6OTJq264sdOQK9Lwz6MZVIuusXEkOzFcQpfXiLa2lh+7Kdi1Kj40t1f9BsvRXF+GbH+JABGvka12UNrycUcrVgMqtpSw3LPQXu4CWIax0MEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781524493; c=relaxed/simple; bh=cMUqqJI4WyS0JP3MHEOAKYJnzm+NpLW5obm9SHA8gz4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kpSFa5uYsxCu4qZI+1VdOF5KPlrm7XD6VOd7C8XmbSiQkZwVfkSH3Jlr2Zu4I00ReRpxRZvtSJyKQz4f2r9GAFG86F8ufqzv0RSlA1UHFfog4euzN2BfOXKRO+ZaQ5HnxQx1mLJlPFo9O1Hf63IbLKHl02b/oghTqZ2e6PkeMYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=b8XHv0jS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="b8XHv0jS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 001471F000E9; Mon, 15 Jun 2026 11:54:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781524492; bh=SVCepHs6d1sEZDL4gFgolTnsiAOHVwL4iSPAe3FhQcU=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=b8XHv0jSnFQKoaQwFvgr1GR1TEC3NhvrdybcD/DZTcJk62W/+Wf+aXq28YaO2Vkvj Z3gICBMopV6ceOwGSSBGqJbFRkt6Hv9DgPuTBn80AxjIQ20cf3de28xpUeobEOPJnv uipfgQlmMyVYxR5d+JEyBwk5Gcizm0NBQP7FM6cCQJI+i0d0TFgCSuFqJS75t23TiD tGrQ/1g3Byjyy50fULV3rIETHPE6n27FZPTolQuqdLUOougcfcjeQynYaaapjdBxwn 75181HZJQA0jujcSzknz9BHcfsJshoz7KIaSRMSiFjFYLJrSkmv1pvergveknivbu/ U1UDeTwFbwbyg== From: "Vlastimil Babka (SUSE)" Date: Mon, 15 Jun 2026 13:54:35 +0200 Subject: [PATCH v3 02/15] mm/slab: stop inlining __slab_alloc_node() Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260615-slab_alloc_flags-v3-2-ce1146d140fb@kernel.org> References: <20260615-slab_alloc_flags-v3-0-ce1146d140fb@kernel.org> In-Reply-To: <20260615-slab_alloc_flags-v3-0-ce1146d140fb@kernel.org> To: Harry Yoo Cc: Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , Suren Baghdasaryan , Alexei Starovoitov , Andrew Morton , Johannes Weiner , Michal Hocko , Shakeel Butt , Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, "Vlastimil Babka (SUSE)" X-Mailer: b4 0.15.2 With sheaves, this is no longer part of the allocation fastpath. For the same reason, also mark the call to it from slab_alloc_node() as unlikely(). Reviewed-by: Harry Yoo (Oracle) Reviewed-by: Hao Li Reviewed-by: Suren Baghdasaryan Link: https://patch.msgid.link/20260610-slab_alloc_flags-v2-3-7190909db118@kernel.org Signed-off-by: Vlastimil Babka (SUSE) --- mm/slub.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index d762cbe5d040..8845e15cb152 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -4519,8 +4519,8 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, return object; } -static __always_inline void *__slab_alloc_node(struct kmem_cache *s, - gfp_t gfpflags, int node, unsigned long addr, size_t orig_size) +static void *__slab_alloc_node(struct kmem_cache *s, gfp_t gfpflags, int node, + unsigned long addr, size_t orig_size) { void *object; @@ -4926,7 +4926,7 @@ static __fastpath_inline void *slab_alloc_node(struct kmem_cache *s, struct list object = alloc_from_pcs(s, gfpflags, node); - if (!object) + if (unlikely(!object)) object = __slab_alloc_node(s, gfpflags, node, addr, orig_size); maybe_wipe_obj_freeptr(s, object); -- 2.54.0