From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7250233993
	for <cgroups@vger.kernel.org>; Thu, 25 Jun 2026 00:10:27 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1782346228; cv=none; b=Jzxj9S6G1P2F5Zj+7iINEjGhnX1LNfSB7AbLmFaJSDHIV6d39wjdHZlL58lMw8UYaPBTH7W/r1TrAtB/cnGVOSYQ0gFhJTLmy7D5PliZT74ZBSp9Ss3pDiEiV69vcfmnAWx+8tfJom3kJJUghhh0pewUvWvGSJC68kvAUdbRQWc=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1782346228; c=relaxed/simple;
	bh=dqmr+0H1Hj/OSIazHjDf33f0kFDVCoEucarJG+xFJA4=;
	h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version; b=F8OczpGWchG+7jtZAzwVoZ9Gr9C5hQydhZgX2bsZH22GdzVw9y7PYT5mG5M5+2Ikfmf2RHvdTrUyt0qlNxsVc7tSNG0Y4B0xtAPFuJTnDwW3czDb3X4D+bQA8zbWJyt0yIcKa2gfiMo/6nF977VNdWwXWqaMRApmKHfFd9t7qqE=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h4Qoor1r; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h4Qoor1r"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 894D51F000E9;
	Thu, 25 Jun 2026 00:10:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1782346227;
	bh=oYYvJ1fa11WriUAAkZ3OTeyNq8CrXyDcpAuJQKIWx9g=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References;
	b=h4Qoor1rOXUgchWCRCHn6zSHUBT8buGsfoJOrRb7VQzL6lvYkx+LVK3DRIQ9vb63e
	 DRsNpY1jz62QQ7gG+DVARZMw23a/AHoO3n+WejIWZyADMyk9m8qt+4vW318o+aHSxc
	 QXZCMgYgvkThofQp3qiM5XK+4ZZdda8iN06dNoBRqBbaWgQRQfkBXHa1Bfmn93EcNK
	 re14wKrEXF3Y5AfsS1pC/hCgs02RgFrnY6+wuAZCxMc2CF4tNIesY57EERgjPUpJUx
	 /+3jZbApi4wbupzv5rg6Qk6aANHsn7EG1PF8qA8f9uZvBCFooS6E6Dc2o6eZ9JOuWW
	 q6suOjpnVX2XQ==
From: SeongJae Park <sj@kernel.org>
To: Joshua Hahn <joshua.hahnjy@gmail.com>
Cc: SeongJae Park <sj@kernel.org>,
	linux-mm@kvack.org,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	Muchun Song <muchun.song@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>,
	cgroups@vger.kernel.org,
	linux-kernel@kvger.kernel.org,
	kernel-team@meta.com
Subject: Re: [PATCH] mm/memcontrol: remove unused for_each_mem_cgroup macro and cleanup
Date: Wed, 24 Jun 2026 17:10:16 -0700
Message-ID: <20260625001018.95717-1-sj@kernel.org>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260624183700.1152742-1-joshua.hahnjy@gmail.com>
References: 
Precedence: bulk
X-Mailing-List: cgroups@vger.kernel.org
List-Id: <cgroups.vger.kernel.org>
List-Subscribe: <mailto:cgroups+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:cgroups+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Wed, 24 Jun 2026 11:36:59 -0700 Joshua Hahn <joshua.hahnjy@gmail.com> wrote:

> Commit 7e1c0d6f58207 ("memcg: switch lruvec stats to rstat") removed the
> last caller of for_each_mem_cgroup back in 2021, and there have not been
> any new callers since. Remove the macro.
> 
> A comment in mem_cgroup_css_online has also been out of date since 2021,
> when 2bfd36374edd9 ("mm: vmscan: consolidate shrinker_maps handling
> code") open-coded the for_each_mem_cgroup iterator. Update the comment.
> 
> Finally, 99430ab8b804c ("mm: introduce BPF kfuncs to access memcg
> statistics and events") added a second declaration for memcg_events to
> include/linux/memcontrol.h, duplicating the one in mm/memcontrol-v1.h.
> Let's clean that up too.
> 
> No functional changes intended.

Nice cleanup, thank you!

> 
> Signed-off-by: Joshua Hahn <joshua.hahnjy@gmail.com>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]