From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5973938D40D for ; Mon, 13 Jul 2026 11:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783942997; cv=none; b=ZiKloGVuhXOCjsmcSE2Z4R3ovqnSu1hhG/F90uyByNrxDsxucj8RERrqbKPQYTJy6JZj79a8GMK7bH2LvnsHxAz3SJiqk33FjMyy0Dslm9+NkKVMWmWAbnQNU5u6I+0SU41wEuD5IcfcckMq2HHLw/gL0BbVZB0nl3ux6jwVbfQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783942997; c=relaxed/simple; bh=sWTQtwbNmhIp1zIM6xBig+wZw3y4IjqXhA4icc8iX9o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=piK8tJh52Dm0Cx4625lH5cPJa7QNf9QX3TIDjBuIwdS339fTKszkg/lbJxQwwreQ/qNtEijytjlaDT8pJfbJLrITJI8rHThP2Amf9Akle99GtkRKVH+i6mN/ElXRIdGGGnQP63x4XTvD8E4WbHU54cXS3/2MIOZuQa/J5kk7q28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=Jj+OBDEf; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="Jj+OBDEf" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-493ec555a26so19852465e9.0 for ; Mon, 13 Jul 2026 04:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1783942995; x=1784547795; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=SeyDTwT5eBKqoeDyITbPcULJkHcUnTXSu2CQ0OyNzGY=; b=Jj+OBDEfPrbeVFPMtvXK+d+F4368Z3JGZtNACzHXYIYNxa2fS/JojcWjzPtbOlxD3a 5gDC1PCfCu5oyBizqgxD3RVhSUNGw3pe0zZp5ungATK1GSbiv5jJ9qAE2ka4SyiMUduV dN0FuJDUlw8s27m1AFQUnJmrGB6Z9+XipJDzhg/Xr+4834xksPMiXSroa5zGSm75vOU+ HhPfd5utfRL4JN7neSBhxum4zyTaj4yCTs5/UBeeXxZzaC0wp5ECFoxEJntr/pUyoc1+ a9sKyC3LtanDNxg7zZZDiLCNo/vTx/37WavEU99YlgOm4V21NwsHzwvfc9BMXqcv59hy dh5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783942995; x=1784547795; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SeyDTwT5eBKqoeDyITbPcULJkHcUnTXSu2CQ0OyNzGY=; b=OJF18mKh4WnqkKUh7Y2E3gvTlUGGR+eOZdPvuPNGAXLLqlHsPorVTykNDkYZVmVLfM Qi+BP1ic2Q45+7SB54IEyOj7cI5FmbGqJdHrtaM3yIoJKqwzGKmYdNqDdd/0qUQakobg YpoIT2E6ZFRcArEIDT1+16T9NvU6yCCulYBWfdomspwvuxkPb/Yu7UbLrVXzbB2HQjtt L/O0hJxSoq3rChw2pQVwGOuoYOptPRekZp3/s0TFr/3Shiw2lU/t6RvRIQNsZIvKW6Cz o6FF1b9QuUHE5URd7iowEXvbntFtj7rl7RApueXytrqwkdmSw0cs+jig5+Q8PzDGfh/T owhw== X-Forwarded-Encrypted: i=1; AHgh+Rr2WOwsnQolahJxCGuT3Ptny435n8D4YnVO9Nrcg9+VTwrpX8boY0ZE1jYRNw/54NZrhYlFHzfX@vger.kernel.org X-Gm-Message-State: AOJu0Yy7yVvqGcYE6pGBek1MGnruDYArwEQIZvBf9ukq08yE3B4NSicA Gh+E6AES58fcFE60Ux80KmVsKxR1V0D8UEy9p7GoFlScnQ7ulDaLmLh+Why6depUQyI= X-Gm-Gg: AfdE7cmAFFBpgk5/vp9X4hmKx3HCfp3Do5JwrQ6/YRX7oe3GeKjwkZGuN0HCbfPGllX zrNa6kFfLzWXyshNbGQLQv86fSmopscw3ZkMYWd9xadP5tzi7/Fg8oD/NxAUJUaJBKh81+k8FMj E58vumiN87hct+iQZet/5FzHjoVqUWzHVa/QcL35d3xdO0gljNgYdxfEo2PKkA041OU2gbofiHY KJuc5WgKL9jipOzL8wLeW1G+DY62R/hNTbqXRcpzDlYm2t7VRuXMKLCZZ76b0QaTsRv1XUQeVsV r/pog92AwL6SJH9inQun53s/7oi9ORzs1QmxFikPySCgD6Zj1nb+r0UbvQHhQGReN30KIQzwYWS ro5jHqM/vY1NymqrezxIP+opMVwTYCEp4ASvYsXVKcbQu6X8Yx5iRIRkUBGTXT1K6dd6xAjHnXE I3jrZVrKxUfu3XKMKx6HKs X-Received: by 2002:a05:600c:5392:b0:490:b00c:8e6a with SMTP id 5b1f17b1804b1-493f8826bbfmr88216405e9.28.1783942994704; Mon, 13 Jul 2026 04:43:14 -0700 (PDT) Received: from localhost ([2a02:8071:6401:180:d892:bf43:a0b4:83b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6f3dcdsm349445725e9.3.2026.07.13.04.43.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 04:43:13 -0700 (PDT) Date: Mon, 13 Jul 2026 07:43:11 -0400 From: Johannes Weiner To: Guopeng Zhang Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Guopeng Zhang Subject: Re: [PATCH] mm: memcg-v1: make mem_cgroup_oom_notify_cb() return void Message-ID: <20260713114311.GL276793@cmpxchg.org> References: <20260713093737.3299646-1-guopeng.zhang@linux.dev> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260713093737.3299646-1-guopeng.zhang@linux.dev> On Mon, Jul 13, 2026 at 05:37:37PM +0800, Guopeng Zhang wrote: > From: Guopeng Zhang > > Commit 7d74b06f240f ("memcg: use for_each_mem_cgroup") replaced the > mem_cgroup_walk_tree() call in mem_cgroup_oom_notify() with > for_each_mem_cgroup_tree(), but left mem_cgroup_oom_notify_cb() with the > int return type required by the old callback interface. > > The function now has a single direct caller and no failure path. Make it > return void. > > Signed-off-by: Guopeng Zhang Acked-by: Johannes Weiner