From: Tao Cui <cui.tao@linux.dev>
To: Tejun Heo <tj@kernel.org>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Josef Bacik" <josef@toxicpanda.com>,
"Jens Axboe" <axboe@kernel.dk>,
cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
cuitao@kylinos.cn, cui.tao@linux.dev
Subject: [PATCH v2 0/2] blk-iolatency: fix io.latency documentation accuracy
Date: Fri, 17 Jul 2026 14:02:23 +0800 [thread overview]
Message-ID: <20260717060225.2019764-1-cui.tao@linux.dev> (raw)
From: Tao Cui <cuitao@kylinos.cn>
Hi,
This series fixes three inaccuracies in the io.latency documentation
(Documentation/admin-guide/cgroup-v2.rst), all caused by the doc
describing only rotational-device behavior:
Patch 1 documents the rotational vs non-rotational difference:
throttling is based on average latency on rotational devices but on the
fraction of IOs that miss the target on non-rotational devices; the
tuning guidance and io.stat field list are updated accordingly
(avg_lat/win are rotational-only; missed/total are documented for
non-rotational devices).
Patch 2 corrects the delay unit: io.stat reports delay_nsec in
nanoseconds, not microseconds as the doc stated.
Both patches are documentation-only and checkpatch-clean.
---
Changes in v2 (address review feedback):
- The non-rotational tuning guidance no longer implies missed/total is a
latency baseline: iolatency reports no average latency for
non-rotational devices, so the target must be chosen from device
characteristics and missed/total only verifies it is being met.
- missed/total are now described as live counters for the current window
(accumulated since the last window boundary), not "the last window":
iolatency_ssd_stat() sums the per-cpu counters without resetting them,
while they are reset at window end by iolatency_check_latencies().
Tao Cui (2):
Docs/admin-guide/cgroup-v2: document io.latency rotational vs
non-rotational behavior
Docs/admin-guide/cgroup-v2: fix delay_nsec unit in io.latency doc
Documentation/admin-guide/cgroup-v2.rst | 55 +++++++++++++++++--------
1 file changed, 38 insertions(+), 17 deletions(-)
--
2.43.0
next reply other threads:[~2026-07-17 6:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 6:02 Tao Cui [this message]
2026-07-17 6:02 ` [PATCH v2 1/2] Docs/admin-guide/cgroup-v2: document io.latency rotational vs non-rotational behavior Tao Cui
2026-07-17 6:02 ` [PATCH v2 2/2] Docs/admin-guide/cgroup-v2: fix delay_nsec unit in io.latency doc Tao Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717060225.2019764-1-cui.tao@linux.dev \
--to=cui.tao@linux.dev \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=cuitao@kylinos.cn \
--cc=hannes@cmpxchg.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox