From: Ziyang Men <ziyang.meme@gmail.com>
To: "Tejun Heo" <tj@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
"Shuah Khan" <shuah@kernel.org>,
kernel-team@meta.com
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Ben Segall <bsegall@google.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
Emil Tsalapatis <emil@etsalapatis.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
JP Kobryn <inwardvessel@gmail.com>,
Ziyang Men <ziyang.meme@gmail.com>,
bpf@vger.kernel.org, cgroups@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] cgroup: expose cpu.stat to BPF
Date: Mon, 17 Aug 2026 17:24:48 -0700 [thread overview]
Message-ID: <20260818002450.3071325-1-ziyang.meme@gmail.com> (raw)
As the title suggests, this series adds bpf kfuncs for the cgroup CPU
controller.
Motivation:
Collecting cgroup statistics is expensive: the existing
method is to open and parse a cgroup file. memcg already has an
efficient alternative through BPF; this series extends that idea to cpu.
Design:
- Add bpf_css_flush_rstat() and bpf_cgroup_base_stat() to cgroup rstat.
The second kfunc returns the raw cgroup_base_stat after the
same cputime adjustment used by cpu.stat.
- Leave reading the CFS bandwidth counters to the BPF program. They are
plain fields of tg->cfs_bandwidth, so they need no kernel code.
- Add bpf_css_to_task_group(), which returns a checked RCU pointer of
the task_group*. This is usefule to compute the throttled time in bpf
side since the bpf_per_cpu_ptr() requires a verifier-known struct
task_group * and a pointer carrying the MEM_PERCPU property.
This use the convention that task_group embeds its css at offset zero,
so no scheduler helper or scheduler source change is needed.
===
Changes since v1:
- Make the rstat flush generic, move it to rstat.c, and take a css.
- Return cgroup_base_stat directly instead of repacking its CPU times.
- Replace the throttled-time aggregation kfunc with a checked RCU cast in
the CPU cgroup BPF code. The cast preserves the verifier type needed for
the BPF program to perform the per-CPU sum itself.
- Remove the changes in the scheduler part.
Tested on VM with v7.2-rc5.
Ziyang Men (2):
cgroup: add BPF kfuncs to read a cpu cgroup's stats
selftests/bpf: add cgroup_iter_cpu test for cpu cgroup kfuncs
kernel/cgroup/Makefile | 2 +
kernel/cgroup/bpf_cpu.c | 61 +++++
kernel/cgroup/rstat.c | 59 +++-
tools/testing/selftests/bpf/cgroup_iter_cpu.h | 22 ++
tools/testing/selftests/bpf/config | 3 +
.../bpf/prog_tests/cgroup_iter_cpu.c | 259 ++++++++++++++++++
.../selftests/bpf/progs/cgroup_iter_cpu.c | 113 ++++++++
7 files changed, 517 insertions(+), 2 deletions(-)
create mode 100644 kernel/cgroup/bpf_cpu.c
create mode 100644 tools/testing/selftests/bpf/cgroup_iter_cpu.h
create mode 100644 tools/testing/selftests/bpf/prog_tests/cgroup_iter_cpu.c
create mode 100644 tools/testing/selftests/bpf/progs/cgroup_iter_cpu.c
--
2.53.0-Meta
next reply other threads:[~2026-08-18 0:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 0:24 Ziyang Men [this message]
2026-08-18 0:24 ` [PATCH v2 1/2] cgroup: add BPF kfuncs to read a cpu cgroup's stats Ziyang Men
2026-08-18 1:28 ` bot+bpf-ci
2026-08-18 17:16 ` Tejun Heo
2026-08-18 22:44 ` Ziyang Men
2026-08-18 22:47 ` Tejun Heo
2026-08-18 23:59 ` Ziyang Men
2026-08-19 20:55 ` Tejun Heo
2026-08-20 20:05 ` Ziyang Men
2026-08-18 0:24 ` [PATCH v2 2/2] selftests/bpf: add cgroup_iter_cpu test for cpu cgroup kfuncs Ziyang Men
2026-08-18 1:28 ` bot+bpf-ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818002450.3071325-1-ziyang.meme@gmail.com \
--to=ziyang.meme@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=bsegall@google.com \
--cc=cgroups@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dietmar.eggemann@arm.com \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=hannes@cmpxchg.org \
--cc=inwardvessel@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox