From: "Michal Koutný" <mkoutny@suse.com>
To: Karl Mehltretter <kmehltretter@gmail.com>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
Li Zefan <lizefan@huawei.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cgroup: Avoid warning when procfs is disabled
Date: Mon, 12 Oct 2026 14:37:32 +0200 [thread overview]
Message-ID: <20261012-robin-handclasp-417c1263d268@there> (raw)
In-Reply-To: <20261012054219.13365-1-kmehltretter@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 596 bytes --]
On Mon, Oct 12, 2026 at 07:42:19AM +0200, Karl Mehltretter <kmehltretter@gmail.com> wrote:
> With CGROUPS=y and PROC_FS=n,
What is practical about this config? Is it real life usage?
> proc_create_single() returns NULL and
> cgroup initialization warns during every boot.
>
> Only check creation of /proc/cgroups when procfs is enabled.
The dependency on CONFIG_PROC_FS is encoded in the
proc_create_single already, it's unfortunate that it returns a value
that signifies an error.
I'd prefer more generic fix that doesn't target cgroup_init()
specifically.
Thanks,
Michal
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]
prev parent reply other threads:[~2026-10-12 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 5:42 [PATCH] cgroup: Avoid warning when procfs is disabled Karl Mehltretter
2026-10-12 12:37 ` Michal Koutný [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012-robin-handclasp-417c1263d268@there \
--to=mkoutny@suse.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kmehltretter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox