From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792964727; b=0nCC2BMXtgDzrEltpBIJd1tJkTtjVOw7hsdi3n8WqaCBFSuV7gTQV0KXbFHbAq4CgDiG 0Mc8HtDedWD58oCdqHG5/8cHdc65i9D8jlIbUATSSNJEPVyfZh+8MUPEI5h+oDf7j1mMs ovzyqwG0P05aTrsA8orY+u/5QkkAhRgmNbTURc3LjnQ0XQXSMB8JZEu3T34vUdGf1U4kI kCMx20dgQSCSi0Iyv/aK1BWGbu3Yh14/90jRD1S/OXgJFuhvDpApgLgWQVqw0fcKhjZ7r B6g3zhSmToz+1tgrgJcjzzS1RPTUByBbay0cJy168CCkApcoN+Z3A+KxNP7EtrJytag== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792964727; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:Received:From:To:Cc:Subject:Date: Message-ID:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-Scanned-By; bh=eHJlwnQsKCIXal/ZPY0INEZh4Dk/VmnivrDCPE+YXYQ=; b=YHHZM0T/t8lX1uvyyfh5NmbiKziPXjw/1fsojvMJhGfjgjXMHpDmCa5MlZ4VPaKblXRb diBFTOJBvkP5RY5OrMfDsHm7bq59rVvgM4pQZmuVdM++bLKKhvNlCR5m9HkHWFB+vzUR+ CmsMCiHVtezRLE8rgqxaPThOIMBzRK1VfDOn0NbNvjq1+5XZE1ULKMbpWnw+K0PxipNEJ avWecbwRxt9b1Mrxeit8VP0AV/27d6uytK8lAVbS3feajkB6NAErJs5MppIY8q5SVFkgx /Vwe/WU/KVxptKLu+9drNc7IW3gL/MOjao7ZM9Th+n2Wpv+rEA/+PUfpuY5DVij670w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=avgXdF3Z; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B25DD606A324 for ; Sun, 25 Oct 2026 21:45:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B25DD606A324 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=avgXdF3Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792964725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eHJlwnQsKCIXal/ZPY0INEZh4Dk/VmnivrDCPE+YXYQ=; b=avgXdF3ZgkTRNSx1hoi9F5nXBs/YtEtTrAtPf79fyYWZQFHpF6Sr8n3scCbVIxh28qOksT BtSPegVCgWU6GHYUS+ZpYEPopkdy3+o1T2Az3A1rbDQKsrgJXY9X4PzVM7PnJYjA+LG3Ws Pc2p/SsD00KtWHzlG9l0u5x/w9qcVbw= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-EBYBxKfRNpKemNFfov8mJQ-1; Sun, 25 Oct 2026 17:45:22 -0400 X-MC-Unique: EBYBxKfRNpKemNFfov8mJQ-1 X-Mimecast-MFC-AGG-ID: EBYBxKfRNpKemNFfov8mJQ_1792964721 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C13DF1956047; Sun, 25 Oct 2026 21:45:20 +0000 (UTC) Received: from llong-thinkpadp16vgen1.redhat.corp (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A4F9A1956089; Sun, 25 Oct 2026 21:45:18 +0000 (UTC) From: Waiman Long To: Ridong Chen , Tejun Heo , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Shuah Khan Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Guopeng Zhang , Waiman Long , Guopeng Zhang Subject: [PATCH-next v3 05/11] selftests/cgroup: Check for a single range nohz_full CPUs before running test matrix Date: Sun, 25 Oct 2026 17:44:43 -0400 Message-ID: <20261025214449.310715-6-longman@redhat.com> In-Reply-To: <20261025214449.310715-1-longman@redhat.com> References: <20261025214449.310715-1-longman@redhat.com> X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Commit 989ca25c10ca ("selftests/cgroup: Add tests for nohz_full housekeeping check") adds a nohz_full test matrix that will only be run when a nohz_full boot parameter cover all the CPUs beyond CPUs 0-7. The code looks for the first and last CPU numbers in the nohz_full sysfs file to determine if that criterion is met. However if there are holes in the range (i.e. has ",") the test matrix may be incorrectly run leading to unexpected test failure. Fix that by skipping "," and anything after that to make sure the first range will cover all the remaining CPUs. Reviewed-by: Guopeng Zhang Tested-by: Guopeng Zhang Fixes: 989ca25c10ca ("selftests/cgroup: Add tests for nohz_full housekeeping check") Signed-off-by: Waiman Long --- tools/testing/selftests/cgroup/test_cpuset_prs.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/cgroup/test_cpuset_prs.sh b/tools/testing/selftests/cgroup/test_cpuset_prs.sh index f4eb984752a0..3c9f67f91366 100755 --- a/tools/testing/selftests/cgroup/test_cpuset_prs.sh +++ b/tools/testing/selftests/cgroup/test_cpuset_prs.sh @@ -111,9 +111,9 @@ echo "" > test/cpuset.cpus # # If nohz_full CPUs have been reserved at boot time, they should not include # CPUs 0-7 as that may fail some of the test cases. On the other hand if the -# set of nohz_full CPUs includes all the CPUs except 0-7, we can run a special -# set of housekeeping CPUs exhaustion tests to see if the cpuset code will -# reject them. +# set of nohz_full CPUs includes all the CPUs except 0-7 in a single range +# -, we can run a special set of housekeeping CPUs exhaustion +# tests to see if the cpuset code will reject them. # FIRST_NOHZ_FULL_CPU= LAST_NOHZ_FULL_CPU= @@ -124,7 +124,7 @@ NOHZ_FULL_CPUS= LAST_PRESENT_CPU=$(cat /sys/devices/system/cpu/present | sed -e "s/.*[,-]//") [[ -n "$NOHZ_FULL_CPUS" ]] && { FIRST_NOHZ_FULL_CPU=$(echo $NOHZ_FULL_CPUS | sed -e "s/[,-].*//") - LAST_NOHZ_FULL_CPU=$(echo $NOHZ_FULL_CPUS | sed -e "s/.*[,-]//") + LAST_NOHZ_FULL_CPU=$(echo $NOHZ_FULL_CPUS | sed -e "s/,.*//;s/.*[-]//") echo "Boot nohz_full CPUs: $NOHZ_FULL_CPUS" } [[ -n "$FIRST_NOHZ_FULL_CPU" && "$FIRST_NOHZ_FULL_CPU" -le 7 ]] && -- 2.56.0