From: Tao Cui <cui.tao@linux.dev>
To: tj@kernel.org, josef@toxicopanda.com, axboe@kernel.dk,
ast@kernel.org, alexei.starovoitov@gmail.com
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
andrii@kernel.org, eddyz87@gmail.com, daniel@iogearbox.net,
linux-kselftest@vger.kernel.org, cui.tao@linux.dev,
cuitao@kylinos.cn, ameryhung@gmail.com
Subject: [RFC PATCH v14 0/4] blk-iocost: BPF struct_ops cost model
Date: Wed, 18 Nov 2026 21:10:25 +0800 [thread overview]
Message-ID: <20261118131029.797007-1-cui.tao@linux.dev> (raw)
From: Tao Cui <cuitao@kylinos.cn>
This series lets a BPF program take over the cost model of one
device. The BPF model provides calc_cost() for charged IOs plus two
transfer coefficients for the completion-time sizing, io.cost.model
selects between the attached model and the builtin one, and enabling
and disabling the controller stays with io.cost.qos.
The builtin model is a linear formula derived from a handful of device
parameters, and the right formula is device specific. A BPF model can
be adapted to the device and updated without rebuilding the kernel.
The series is based on next-20261117.
Changes since v13:
- p1: stop updating attached and attached_link under ioc->lock;
rq_qos_mutex already orders all their accessors (review from tj)
- p1: name the calc_cost flags enum iocost_calc_flags and rename
ioc_model()/model to ioc_bpf_model()/bpf_model so that the
builtin model isn't called a NULL model (review from tj)
- p1: document why iocost holds its own model reference, the
field locking and the merge flag semantics, and reword the
commit message to describe guarantees instead of code paths
(review from tj)
- p1: clear the autop stepping timestamps when a BPF model is
attached; without this, the timestamps from before the attach
survive until a model=linear switchback and can trigger an
immediate profile step on that stale pre-attach evidence
(report from sashiko)
- p1: align the BPF pricing scope with the builtin model:
dataless bios with no flush state and ops other than reads,
writes and zone appends cost nothing, completion-time sizing
prices reads, writes and zone appends, and a dead owning map no
longer reports -EBUSY (report from sashiko)
- p3: probe the iocost_ioc_tick tracepoint, unwind the private
mount namespace on setup failure, report fopen errors faithfully
and fix an inverted posix_memalign() assertion that made the
streams test skip its whole IO block (report from sashiko)
- p2/p4: document the iocost_ioc_tick fields in the trace header
and extend the io.cost.model docs with the dev supply and the
-ENODEV attach conditions (report from sashiko)
Tested on next-20261117 (qemu x86_64): the selftests pass, and the 2x
example model doubles the charged cost over the builtin on a
rotational device (2.00x measured), returning to 1.00x after
"model=linear".
Link: https://lore.kernel.org/r/20261106122356.3224638-1-cui.tao@linux.dev # v13
Tao Cui (4):
blk-iocost: add BPF struct_ops cost model support
blk-iocost: add iocost_ioc_tick tracepoint for per-period device
summary
selftests/bpf: add iocost cost model test
docs: cgroup-v2: document the iocost BPF cost model attachment
Documentation/admin-guide/cgroup-v2.rst | 55 +-
MAINTAINERS | 1 +
block/Kconfig | 4 +
block/blk-iocost.c | 360 ++++++-
include/trace/events/iocost.h | 57 ++
tools/testing/selftests/bpf/config | 2 +
.../selftests/bpf/prog_tests/iocost_model.c | 947 ++++++++++++++++++
.../selftests/bpf/progs/iocost_model.c | 188 ++++
tools/testing/selftests/bpf/progs/iocost_ms.c | 195 ++++
9 files changed, 1797 insertions(+), 12 deletions(-)
create mode 100644 tools/testing/selftests/bpf/prog_tests/iocost_model.c
create mode 100644 tools/testing/selftests/bpf/progs/iocost_model.c
create mode 100644 tools/testing/selftests/bpf/progs/iocost_ms.c
next reply other threads:[~2026-11-18 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 13:10 Tao Cui [this message]
2026-11-18 13:10 ` [RFC PATCH v14 1/4] blk-iocost: add BPF struct_ops cost model support Tao Cui
2026-11-18 13:10 ` [RFC PATCH v14 2/4] blk-iocost: add iocost_ioc_tick tracepoint for per-period device summary Tao Cui
2026-11-18 13:49 ` bot+bpf-ci
2026-11-18 13:10 ` [RFC PATCH v14 3/4] selftests/bpf: add iocost cost model test Tao Cui
2026-11-18 13:49 ` bot+bpf-ci
2026-11-18 13:10 ` [RFC PATCH v14 4/4] docs: cgroup-v2: document the iocost BPF cost model attachment Tao Cui
2026-11-18 13:17 ` [RFC PATCH v14 0/4] blk-iocost: BPF struct_ops cost model Tao Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118131029.797007-1-cui.tao@linux.dev \
--to=cui.tao@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=cuitao@kylinos.cn \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=josef@toxicopanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox