From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C980B21CC7D for ; Fri, 7 Mar 2025 15:17:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741360631; cv=none; b=XHmwS4AnD0iW0cUPBMJ2H0aLOl/AJKW34BS/soBPngRXyseR56LeOfpfwRAAnxkhyts1r+gjezRYFsfPbKWDDLUKNeVpha/xW0fxk+bCaFwyB2Lk96vV7G/ozGrAyZdygwtjYAhlcYtfLppcImD5Qcr9QncetsSdEYs1igZ1cks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741360631; c=relaxed/simple; bh=u1ia+jgdTy6SEy3Z41USO6FQmaZmpeo4fLS9jAxShW0=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=B3iIq1emmPUjeTdGi1j1cXCcRdTkzo+ORz18LcnimecqquzxkMOk6gEAzBhtw6yCv4BBxa5eJ1O4R/xgzoJvUA8efKPOe73MYMNtXNhpEOdlyc8dt1Lrq+c88e3xYLRnbvEix4WDD4FC7BQqp0H0nxVjfKwyhbMjX8Miz1toJHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hWcBSsbK; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hWcBSsbK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741360627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jSf6oeIJqNd7y0EfyhKwRUYW2AS0darN35r1LLf0w2A=; b=hWcBSsbKGe6Sh495dI/ML//F1e4Lcg8sHK1AQpHO2x0StLYep18JH95txX2Y8wwo33Gis4 7Tl1+1zlJMJFmU7dFfbkbi5bAQ5r4M4Un0THI2CUrnDfTIHcFXd7WVPLKvULyVMIU28aS8 6fnghiwbJwKYpqBPEwm1flUksLrnEmI= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-534-jfRH3ejsO_uqkUDfdeCc1A-1; Fri, 07 Mar 2025 10:17:06 -0500 X-MC-Unique: jfRH3ejsO_uqkUDfdeCc1A-1 X-Mimecast-MFC-AGG-ID: jfRH3ejsO_uqkUDfdeCc1A_1741360626 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c3c0ccf1d3so650838985a.0 for ; Fri, 07 Mar 2025 07:17:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741360626; x=1741965426; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jSf6oeIJqNd7y0EfyhKwRUYW2AS0darN35r1LLf0w2A=; b=AS2QEevpaD3Q4B5Qkdq9JtmBa4Wz+np7CaK3j65M494ChUrqJVgDl4SBBVFDzyN1/x lvsF/gJDdlXVkYS0guCdCqfTQ8VLvhSDdmblrk+HH4zgm0gzgHe7P4rtglZ/HpMqeJI6 a0k/OsAqrPWo6hC/q/zXJJ+Z5qpsYCCZmDIDEfGJyBTEmT6jEC71xdAXhHVk6y7gTEDv OzHA5YKSLtP8l6eGgMuaAX4k/5aomciGiwNY0x7bR79uNoskj8/eMc5KryZ6lNeypnwk z+/+w1iV5ip9nL/qZTZN8lhqYz1DRb2XQFPZ9ReQu74hox4MWghCTtsE+J/7PzJeLQY5 Uh9w== X-Forwarded-Encrypted: i=1; AJvYcCVZD6HtHXYyQINs3TmdOJbDs16POwDwsp6vmn1uzs5ShCKTNpPT9DBuUpfBIGEYmPBSrxmF29A3@vger.kernel.org X-Gm-Message-State: AOJu0Yya20jFuTqK3LthFtW1+FFr6+OK3NAsj7eoD+Xah1ggtAJi4dcr waC6XCvIq4vWhrxP388I3noLkXhgJkSNWN/V4XttZ2h5XGDXQuSgkc4KiGlGqoEGPYry2Uu/1MO H6Ehwbq3S3rhOniRekDWZMXWxNBJqPGJh4u2rVboaSSlA2cVL37vYAGw= X-Gm-Gg: ASbGncs7KsPHylYufy+qKdztaDDb99bjgG3nrDtGgsFnEZJ0+rLtOYDrTcKp2yRyLd5 hyyArxx8+BJy/3EGNtQvP8bx7hDBi5hdFa5yXn+1/KzoCBjngoQD2mgYCvQUjohg/vRBJqWII5f Nyl4WRa3th6UEZd9txuaTiTl2ww2dOtvB2dViWitwpWDi92ELYXerIXf5k2BC2PNBE6XpHIX0CJ VvM1ARawwDJbTRQ7gJBdWpm8XDlEIRomYbdmf9R3Zsbw8kbT8i5rcINEk5nUiVUYw/ZQj/rgYtc aVtYs6wkdaZZN+jVvEx/aPBGjqkbCIgT61nI66UOhSeugyVEYLRCN8abFvg= X-Received: by 2002:ac8:7c41:0:b0:471:9dd6:b51a with SMTP id d75a77b69052e-475c677efa5mr54668601cf.21.1741360625797; Fri, 07 Mar 2025 07:17:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IG7evF0XJq+z5QXXPTC1cKhMgQOZY905OvJ26UXCPt4pNptuMXkQbcvcKa3pfRIHeSjuvtbHw== X-Received: by 2002:ac8:7c41:0:b0:471:9dd6:b51a with SMTP id d75a77b69052e-475c677efa5mr54668161cf.21.1741360625415; Fri, 07 Mar 2025 07:17:05 -0800 (PST) Received: from ?IPV6:2601:188:c100:5710:627d:9ff:fe85:9ade? ([2601:188:c100:5710:627d:9ff:fe85:9ade]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4751db2f961sm21123951cf.62.2025.03.07.07.17.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Mar 2025 07:17:04 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <234d750d-cd2e-43b2-8133-43ca1fd889de@redhat.com> Date: Fri, 7 Mar 2025 10:17:03 -0500 Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 8/8] include/{topology,cpuset}: Move dl_rebuild_rd_accounting to cpuset.h To: Juri Lelli , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Tejun Heo , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter , Waiman Long References: <20250306141016.268313-1-juri.lelli@redhat.com> <20250306141016.268313-9-juri.lelli@redhat.com> Content-Language: en-US In-Reply-To: <20250306141016.268313-9-juri.lelli@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/6/25 9:10 AM, Juri Lelli wrote: > dl_rebuild_rd_accounting() is defined in cpuset.c, so it makes more > sense to move related declarations to cpuset.h. > > Implement the move. > > Suggested-by: Waiman Long > Signed-off-by: Juri Lelli > --- > include/linux/cpuset.h | 5 +++++ > include/linux/sched/topology.h | 2 -- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h > index 835e7b793f6a..c414daa7d503 100644 > --- a/include/linux/cpuset.h > +++ b/include/linux/cpuset.h > @@ -125,6 +125,7 @@ static inline int cpuset_do_page_mem_spread(void) > > extern bool current_cpuset_is_being_rebound(void); > > +extern void dl_rebuild_rd_accounting(void); > extern void rebuild_sched_domains(void); > > extern void cpuset_print_current_mems_allowed(void); > @@ -259,6 +260,10 @@ static inline bool current_cpuset_is_being_rebound(void) > return false; > } > > +static inline void dl_rebuild_rd_accounting(void) > +{ > +} > + > static inline void rebuild_sched_domains(void) > { > partition_sched_domains(1, NULL, NULL); > diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h > index 96e69bfc3c8a..51f7b8169515 100644 > --- a/include/linux/sched/topology.h > +++ b/include/linux/sched/topology.h > @@ -166,8 +166,6 @@ static inline struct cpumask *sched_domain_span(struct sched_domain *sd) > return to_cpumask(sd->span); > } > > -extern void dl_rebuild_rd_accounting(void); > - > extern void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[], > struct sched_domain_attr *dattr_new); > Reviewed-by: Waiman Long