From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu Kuai Subject: Re: [PATCH -next v5 0/8] bugfix and cleanup for blk-throttle Date: Thu, 2 Jun 2022 19:14:36 +0800 Message-ID: <244865d4-e7e7-432f-8e9c-248ab900d283@huawei.com> References: <20220528064330.3471000-1-yukuai3@huawei.com> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20220528064330.3471000-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> List-ID: Content-Type: text/plain; charset="iso-8859-1"; format="flowed" To: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mkoutny-IBi9RG/b67k@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org =D4=DA 2022/05/28 14:43, Yu Kuai =D0=B4=B5=C0: > Changes in v5: > - add comments in patch 4 > - clear bytes/io_skipped in throtl_start_new_slice_with_credit() in > patch 4 > - and cleanup patches 5-8 > Changes in v4: > - add reviewed-by tag for patch 1 > - add patch 2,3 > - use a different way to fix io hung in patch 4 > Changes in v3: > - fix a check in patch 1 > - fix link err in patch 2 on 32-bit platform > - handle overflow in patch 2 > Changes in v2: > - use a new solution suggested by Ming > - change the title of patch 1 > - add patch 2 >=20 > Patch 1 fix that blk-throttle can't work if multiple bios are throttle, > Patch 2 fix overflow while calculating wait time > Patch 3,4 fix io hung due to configuration updates. > Patch 5-8 are cleanup patches, there are no functional changes, just > some places that I think can be optimized during code review. friendly ping ... >=20 > Previous version: > v1: https://lore.kernel.org/all/20220517134909.2910251-1-yukuai3-hv44wF8L= i93QT0dZR+AlfA@public.gmane.org/ > v2: https://lore.kernel.org/all/20220518072751.1188163-1-yukuai3-hv44wF8L= i93QT0dZR+AlfA@public.gmane.org/ > v3: https://lore.kernel.org/all/20220519085811.879097-1-yukuai3-hv44wF8Li= 93QT0dZR+AlfA@public.gmane.org/ > v4: https://lore.kernel.org/all/20220523082633.2324980-1-yukuai3-hv44wF8L= i93QT0dZR+AlfA@public.gmane.org/ >=20 > Yu Kuai (8): > blk-throttle: fix that io throttle can only work for single bio > blk-throttle: prevent overflow while calculating wait time > blk-throttle: factor out code to calculate ios/bytes_allowed > blk-throttle: fix io hung due to config updates > blk-throttle: use 'READ/WRITE' instead of '0/1' > blk-throttle: calling throtl_dequeue/enqueue_tg in pairs > blk-throttle: cleanup tg_update_disptime() > blk-throttle: clean up flag 'THROTL_TG_PENDING' >=20 > block/blk-throttle.c | 158 +++++++++++++++++++++++++++++-------------- > block/blk-throttle.h | 16 +++-- > 2 files changed, 120 insertions(+), 54 deletions(-) >=20