Linux cgroups development
 help / color / mirror / Atom feed
From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
To: "Harry Yoo (Meta)" <harry@kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	Muchun Song <muchun.song@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexei Starovoitov <ast@kernel.org>, Hao Li <hao.li@linux.dev>,
	Christoph Lameter <cl@gentwo.org>,
	David Rientjes <rientjes@google.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Clark Williams <clrkwllms@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>
Cc: kernel-team@meta.com, cgroups@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH for-next v3 7/7] mm/slab: call debug_locks and KCSAN checks in kfree_nolock()
Date: Wed, 18 Nov 2026 17:58:23 +0100	[thread overview]
Message-ID: <2650b0d0-49a9-450c-af6a-df1aa129c3b7@kernel.org> (raw)
In-Reply-To: <20261115-kmalloc-nolock-fixes-v3-7-9034dd4ecaab@kernel.org>

On 11/15/26 16:09, Harry Yoo (Meta) wrote:
> kfree_nolock() skips free hooks that may acquire spinlocks because it
> can be called from any context. debug_check_no_locks_freed() and
> __kcsan_check_access() are skipped as well.
> 
> However, they acquire a spinlock only when they report a bug.
> debug_check_no_locks_freed() disables interrupts and walks
> current->held_locks, and reaches printk only when a held lock is inside
> the freed object. KCSAN takes report_lock only when it observes a race.
> 
> Just like KASAN, take the risk of potential deadlock for bug reporting.
> Call debug_check_no_locks_freed() and __kcsan_check_access() regardless
> of allow_spin.
> 
> Signed-off-by: Harry Yoo (Meta) <harry@kernel.org>

Seems fair.

Reviewed-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>

> ---
>  mm/slub.c | 25 ++++++++++++-------------
>  1 file changed, 12 insertions(+), 13 deletions(-)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index fd3de3bee1de..fad19ec6af4b 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2708,19 +2708,25 @@ bool slab_free_hook(struct kmem_cache *s, void *x, unsigned int free_flags)
>  
>  	kmsan_slab_free(s, x);
>  
> +	/*
> +	 * debug_locks, KCSAN, KASAN may acquire a spinlock to report a bug,
> +	 * but otherwise cannot deadlock. Take the risk of deadlock for
> +	 * reporting.
> +	 */
> +	debug_check_no_locks_freed(x, s->object_size);
> +
> +	/* Use KCSAN to help debug racy use-after-free. */
> +	if (!still_accessible)
> +		__kcsan_check_access(x, s->object_size,
> +				     KCSAN_ACCESS_WRITE | KCSAN_ACCESS_ASSERT);
> +
>  	/* Hooks that acquire locks or kmalloc_nolock() skips alloc hook counterpart */
>  	if (likely(allow_spin)) {
>  		kmemleak_free_recursive(x, s->flags);
> -		debug_check_no_locks_freed(x, s->object_size);
>  
>  		if (!(s->flags & SLAB_DEBUG_OBJECTS))
>  			debug_check_no_obj_freed(x, s->object_size);
>  
> -		/* Use KCSAN to help debug racy use-after-free. */
> -		if (!still_accessible)
> -			__kcsan_check_access(x, s->object_size,
> -					     KCSAN_ACCESS_WRITE | KCSAN_ACCESS_ASSERT);
> -
>  		if (kfence_free(x))
>  			return false;
>  	}
> @@ -2728,13 +2734,6 @@ bool slab_free_hook(struct kmem_cache *s, void *x, unsigned int free_flags)
>  	/*
>  	 * Give KASAN a chance to notice an invalid free operation before we
>  	 * modify the object.
> -	 *
> -	 * If KASAN finds a bug it will do kasan_report_invalid_free() which
> -	 * will call raw_spin_lock_irqsave() which is technically unsafe from
> -	 * NMI, but take chance and report kernel bug. The sequence of
> -	 * kasan_report_invalid_free() -> raw_spin_lock_irqsave() -> NMI
> -	 * -> kfree_nolock() -> kasan_report_invalid_free() on the same CPU
> -	 *  is double buggy and deserves to deadlock.
>  	 */
>  	if (kasan_slab_pre_free(s, x))
>  		return false;
> 


      reply	other threads:[~2026-11-18 16:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 15:09 [PATCH for-next v3 0/7] memcg,slab: kmalloc_nolock() fixes Harry Yoo (Meta)
2026-11-15 15:09 ` [PATCH for-next v3 1/7] mm/memcontrol: defer obj_cgroup_release() to irq_work Harry Yoo (Meta)
2026-11-15 15:09 ` [PATCH for-next v3 2/7] mm/slab: pass free_flags to slab_free_hook() Harry Yoo (Meta)
2026-11-18 15:21   ` Vlastimil Babka (SUSE)
2026-11-15 15:09 ` [PATCH for-next v3 3/7] mm/slab: handle SLAB_FREE_NOLOCK in slab_free_hook() instead of open coding Harry Yoo (Meta)
2026-11-18 15:54   ` Vlastimil Babka (SUSE)
2026-11-15 15:09 ` [PATCH for-next v3 4/7] mm/slab: fix a deadlock in memcg_alloc_abort_single() Harry Yoo (Meta)
2026-11-18 16:24   ` Vlastimil Babka (SUSE)
2026-11-15 15:09 ` [PATCH for-next v3 5/7] mm/slab: serialize deferred_work_barrier() Harry Yoo (Meta)
2026-11-15 15:09 ` [PATCH for-next v3 6/7] mm/slab: refactor free_to_pcs() Harry Yoo (Meta)
2026-11-18 16:32   ` Vlastimil Babka (SUSE)
2026-11-15 15:09 ` [PATCH for-next v3 7/7] mm/slab: call debug_locks and KCSAN checks in kfree_nolock() Harry Yoo (Meta)
2026-11-18 16:58   ` Vlastimil Babka (SUSE) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2650b0d0-49a9-450c-af6a-df1aa129c3b7@kernel.org \
    --to=vbabka@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=cgroups@vger.kernel.org \
    --cc=cl@gentwo.org \
    --cc=clrkwllms@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=hao.li@linux.dev \
    --cc=harry@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=shakeel.butt@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox