From: David Howells <dhowells@redhat.com>
To: Andrei Vagin <avagin@virtuozzo.com>
Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Tejun Heo <tj@kernel.org>
Subject: Re: [16/32] kernfs, sysfs, cgroup, intel_rdt: Support fs_context [ver #8]
Date: Fri, 22 Jun 2018 13:52:16 +0100 [thread overview]
Message-ID: <29799.1529671936@warthog.procyon.org.uk> (raw)
In-Reply-To: <20180621184754.GB21326@outlook.office365.com>
Andrei Vagin <avagin@virtuozzo.com> wrote:
> ret = 0;
> + ctx->root = root;
> goto out_unlock;
Okay, I can see that.
> percpu_ref_reinit(&root->cgrp.self.refcnt);
> mutex_unlock(&cgroup_mutex);
> }
> + cgroup_get(&root->cgrp);
This probably needs to be conditional on ret == 0.
Which version are you testing btw? The patches in git have been fixed a
little from what was last posted.
David
next prev parent reply other threads:[~2018-06-22 12:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <152720682792.9073.14747437198191460035.stgit@warthog.procyon.org.uk>
2018-06-21 18:47 ` [16/32] kernfs, sysfs, cgroup, intel_rdt: Support fs_context [ver #8] Andrei Vagin
2018-06-22 12:52 ` David Howells [this message]
2018-06-22 15:30 ` Andrei Vagin
2018-06-22 16:57 ` Andrei Vagin
2018-06-23 23:34 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29799.1529671936@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=avagin@virtuozzo.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox