public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Yu Kuai <yukuai1@huaweicloud.com>,
	hch@lst.de, tj@kernel.org, josef@toxicpanda.com,
	yukuai3@huawei.com
Cc: lukas.bulwahn@gmail.com, cgroups@vger.kernel.org,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH -next v2 0/6] blk-wbt: minor fix and cleanup
Date: Fri, 12 May 2023 08:58:11 -0600	[thread overview]
Message-ID: <2b18e6ed-bce0-44f5-5ec4-8903f3c85cfe@kernel.dk> (raw)
In-Reply-To: <20230512093554.911753-1-yukuai1@huaweicloud.com>

On 5/12/23 3:35 AM, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
> 
> Changes in v2:
>  - make the code more readable for patch 1
>  - add a new attr_group that is only visible for rq based device
>  - explain in detail for patch 4
>  - add review tag for patch 2,3,5
> 
> Yu Kuai (6):
>   blk-wbt: fix that wbt can't be disabled by default
>   blk-wbt: don't create wbt sysfs entry if CONFIG_BLK_WBT is disabled
>   blk-wbt: remove dead code to handle wbt enable/disable with io
>     inflight
>   blk-wbt: cleanup rwb_enabled() and wbt_disabled()
>   blk-iocost: move wbt_enable/disable_default() out of spinlock
>   blk-sysfs: add a new attr_group for blk_mq
> 
>  block/blk-iocost.c |   7 +-
>  block/blk-sysfs.c  | 181 ++++++++++++++++++++++++++-------------------
>  block/blk-wbt.c    |  33 +++------
>  block/blk-wbt.h    |  19 -----
>  4 files changed, 117 insertions(+), 123 deletions(-)

We need a 6.4 version of the fix to get rid of the regression. If you
want to do cleanups on top of that, then that's fine and that can go into
6.5. But don't mix them up.

-- 
Jens Axboe



  parent reply	other threads:[~2023-05-12 14:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12  9:35 [PATCH -next v2 0/6] blk-wbt: minor fix and cleanup Yu Kuai
2023-05-12  9:35 ` [PATCH -next v2 1/6] blk-wbt: fix that wbt can't be disabled by default Yu Kuai
2023-05-12  9:59   ` Chengming Zhou
2023-05-12 14:57   ` Christoph Hellwig
2023-05-12  9:35 ` [PATCH -next v2 2/6] blk-wbt: don't create wbt sysfs entry if CONFIG_BLK_WBT is disabled Yu Kuai
2023-05-12 14:57   ` Christoph Hellwig
2023-05-12  9:35 ` [PATCH -next v2 3/6] blk-wbt: remove dead code to handle wbt enable/disable with io inflight Yu Kuai
     [not found] ` <20230512093554.911753-1-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2023-05-12  9:35   ` [PATCH -next v2 4/6] blk-wbt: cleanup rwb_enabled() and wbt_disabled() Yu Kuai
     [not found]     ` <20230512093554.911753-5-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2023-05-12 14:58       ` Christoph Hellwig
2023-05-12  9:35   ` [PATCH -next v2 5/6] blk-iocost: move wbt_enable/disable_default() out of spinlock Yu Kuai
2023-05-12 14:58     ` Christoph Hellwig
2023-05-12  9:35 ` [PATCH -next v2 6/6] blk-sysfs: add a new attr_group for blk_mq Yu Kuai
     [not found]   ` <20230512093554.911753-7-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2023-05-26  9:38     ` Yu Kuai
2023-05-26 12:34       ` Christoph Hellwig
2023-05-12 14:58 ` Jens Axboe [this message]
     [not found]   ` <2b18e6ed-bce0-44f5-5ec4-8903f3c85cfe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2023-05-22 12:00     ` [PATCH -next v2 0/6] blk-wbt: minor fix and cleanup Linux regression tracking (Thorsten Leemhuis)
     [not found]       ` <5d53e634-33c2-e040-3c34-6c36e32eed81-rCxcAJFjeRkk+I/owrrOrA@public.gmane.org>
2023-05-22 12:12         ` Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b18e6ed-bce0-44f5-5ec4-8903f3c85cfe@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=hch@lst.de \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=tj@kernel.org \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox