From: David Laight <David.Laight@ACULAB.COM>
To: 'Tejun Heo' <tj@kernel.org>, Carlos Bilbao <carlos.bilbao@amd.com>
Cc: "josef@toxicpanda.com" <josef@toxicpanda.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
amd <amd@localhost.localdomain>
Subject: RE: [PATCH] blk-iocost: fix seq_printf compile type mismatch error
Date: Wed, 19 Jul 2023 08:57:32 +0000 [thread overview]
Message-ID: <2b4540aadc3c4449a192aeed6211f232@AcuMS.aculab.com> (raw)
In-Reply-To: <ZLWNHuTGk0fy8pjE@slm.duckdns.org>
From: Tejun Heo
> Sent: 17 July 2023 19:49
>
> On Mon, Jul 17, 2023 at 09:18:52AM -0500, Carlos Bilbao wrote:
> > From: amd <amd@localhost.localdomain>
> >
> > Fix two type mismatch errors encountered while compiling blk-iocost.c with
> > GCC version 13.1.1 that involved constant operator WEIGHT_ONE. Cast the
> > result of the division operation to (unsigned int) to match the expected
> > format specifier %u in two seq_printf invocations.
>
> Can you detail the warnings? Was that on 32bit compiles?
The problem is caused by gcc 13 changing the types of the
constants inside an enum to be all the same.
The best fix is (probably) to replace all the enum used to
define unrelated constants with #defines.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2023-07-19 8:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230717141852.153965-1-carlos.bilbao@amd.com>
[not found] ` <20230717141852.153965-1-carlos.bilbao-5C7GfCeVMHo@public.gmane.org>
2023-07-17 14:23 ` [PATCH] blk-iocost: fix seq_printf compile type mismatch error Carlos Bilbao
2023-07-17 18:49 ` Tejun Heo
[not found] ` <ZLWNHuTGk0fy8pjE-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2023-07-18 15:37 ` Carlos Bilbao
2023-07-20 20:05 ` Tejun Heo
2023-07-19 8:57 ` David Laight [this message]
[not found] ` <2b4540aadc3c4449a192aeed6211f232-1XygrNkDbNvwg4NCKwmqgw@public.gmane.org>
2023-07-20 20:06 ` 'Tejun Heo'
2023-07-21 8:05 ` David Laight
[not found] ` <fd89f72848da4569a19ec8a1ac9ec94e-1XygrNkDbNvwg4NCKwmqgw@public.gmane.org>
2023-07-21 17:58 ` 'Tejun Heo'
2023-07-21 22:32 ` Carlos Bilbao
[not found] ` <93557f79-c12c-3c3f-2c25-9ba50a618daa-5C7GfCeVMHo@public.gmane.org>
2023-07-22 1:14 ` Tejun Heo
[not found] ` <ZLstYbAzqkqwIRzy-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2023-07-31 15:04 ` Carlos Bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b4540aadc3c4449a192aeed6211f232@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=amd@localhost.localdomain \
--cc=axboe@kernel.dk \
--cc=carlos.bilbao@amd.com \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox