public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Yu Kuai <yukuai1@huaweicloud.com>,
	jack@suse.cz, tj@kernel.org, josef@toxicpanda.com,
	paolo.valente@unimore.it, mauro.andreolini@unimore.it,
	avanzini.arianna@gmail.com
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, yukuai3@huawei.com,
	yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH for-6.12 0/4] block, bfq: fix corner cases related to bfqq merging
Date: Tue, 3 Sep 2024 09:51:42 -0600	[thread overview]
Message-ID: <2ee05037-fb4f-4697-958b-46f0ae7d9cdd@kernel.dk> (raw)
In-Reply-To: <20240902130329.3787024-1-yukuai1@huaweicloud.com>

On 9/2/24 7:03 AM, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
> 
> Our syzkaller report a UAF problem(details in patch 1), however it can't
> be reporduced. And this set are some corner cases fix that might be
> related, and they are found by code review.
> 
> Yu Kuai (4):
>   block, bfq: fix possible UAF for bfqq->bic with merge chain
>   block, bfq: choose the last bfqq from merge chain in
>     bfq_setup_cooperator()
>   block, bfq: don't break merge chain in bfq_split_bfqq()
>   block, bfq: use bfq_reassign_last_bfqq() in bfq_bfqq_move()
> 
>  block/bfq-cgroup.c  |  7 +------
>  block/bfq-iosched.c | 17 +++++++++++------
>  block/bfq-iosched.h |  2 ++
>  3 files changed, 14 insertions(+), 12 deletions(-)

BFQ is effectively unmaintained, and has been for quite a while at
this point. I'll apply these, thanks for looking into it, but I think we
should move BFQ to an unmaintained state at this point.

-- 
Jens Axboe



  parent reply	other threads:[~2024-09-03 15:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-02 13:03 [PATCH for-6.12 0/4] block, bfq: fix corner cases related to bfqq merging Yu Kuai
2024-09-02 13:03 ` [PATCH for-6.12 1/4] block, bfq: fix possible UAF for bfqq->bic with merge chain Yu Kuai
2024-09-04 11:51   ` Jan Kara
2024-09-02 13:03 ` [PATCH for-6.12 2/4] block, bfq: choose the last bfqq from merge chain in bfq_setup_cooperator() Yu Kuai
2024-09-04 12:17   ` Jan Kara
2024-09-02 13:03 ` [PATCH for-6.12 3/4] block, bfq: don't break merge chain in bfq_split_bfqq() Yu Kuai
2024-09-04 12:20   ` Jan Kara
2024-09-02 13:03 ` [PATCH for-6.12 4/4] block, bfq: use bfq_reassign_last_bfqq() in bfq_bfqq_move() Yu Kuai
2024-09-04 12:22   ` Jan Kara
2024-09-03 15:51 ` Jens Axboe [this message]
2024-09-04  1:32   ` [PATCH for-6.12 0/4] block, bfq: fix corner cases related to bfqq merging Yu Kuai
2024-09-04  2:28     ` Bart Van Assche
2024-09-04  2:45       ` Yu Kuai
2024-09-04 13:55         ` Jens Axboe
2024-09-04 17:17         ` Bart Van Assche
2024-09-05  1:48           ` Yu Kuai
2024-09-04  4:38     ` Ming Lei
2024-09-04 12:29     ` Jan Kara
2024-09-04 13:49       ` Jens Axboe
2024-09-04 13:53     ` Jens Axboe
2024-09-03 15:56 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ee05037-fb4f-4697-958b-46f0ae7d9cdd@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=avanzini.arianna@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=jack@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mauro.andreolini@unimore.it \
    --cc=paolo.valente@unimore.it \
    --cc=tj@kernel.org \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox