From: xuejiufei <xuejiufei@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@fb.com>, Shaohua Li <shli@kernel.org>,
linux-block@vger.kernel.org, cgroups@vger.kernel.org,
jinli.zjl@alibaba-inc.com, qijiang.qj@alibaba-inc.com
Subject: Re: [RFC PATCH] blk-throttle: dispatch more sync writes in block throttle layer
Date: Wed, 10 Jan 2018 09:44:43 +0800 [thread overview]
Message-ID: <37158a6a-ff0d-10e7-c39b-9d588b5f50d2@gmail.com> (raw)
In-Reply-To: <20180109145659.GG3668920@devbig577.frc2.facebook.com>
Hi Tejun,
On 2018/1/9 下午10:56, Tejun Heo wrote:
> Hello,
>
> On Tue, Jan 09, 2018 at 12:45:13PM +0800, xuejiufei wrote:
>> 1. A bio is charged according to the direction, if we put the reads
>> and sync writes together, we need to search the queue to pick a
>> certain number of read and write IOs when the limit is not reached.
>
> Ah, you're right.
>
>> 2. I found that the multi-queue scheduler kyber also has three queues:
>> one for read, one for sync write and one for others. This patch
>> introduces another queue for async writes and others just like kyber.
>
> Yeah, it'd make sense to make that a separate queue then.
>
Could you please review this patch and give some advice?
Thanks.
Jiufei Xue
> Thanks.
>
prev parent reply other threads:[~2018-01-10 1:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 5:16 [RFC PATCH] blk-throttle: dispatch more sync writes in block throttle layer xuejiufei
2018-01-08 12:07 ` Tejun Heo
[not found] ` <20180108120742.GJ3668920-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2018-01-09 4:45 ` xuejiufei
2018-01-09 14:56 ` Tejun Heo
2018-01-10 1:44 ` xuejiufei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37158a6a-ff0d-10e7-c39b-9d588b5f50d2@gmail.com \
--to=xuejiufei@gmail.com \
--cc=axboe@fb.com \
--cc=cgroups@vger.kernel.org \
--cc=jinli.zjl@alibaba-inc.com \
--cc=linux-block@vger.kernel.org \
--cc=qijiang.qj@alibaba-inc.com \
--cc=shli@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox