From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBFBA401A13 for ; Thu, 9 Jul 2026 09:49:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783590595; cv=none; b=u1zFU+WGEKPZosgygrHkIQu2/bIQof5IGLIDmnZyx6+gFVXwu6J3g/vnuhnkUMZ+vkM+MIfzsRjWIOhPzbhNH9vqrfHXFRqY3qNRF5r7J0n7vg3MqS4kxpRb7A6iNnZyXhItsVpMI6MwSB2yQ1Kr9uVYspzWYSC86dS4vX3cmYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783590595; c=relaxed/simple; bh=jTFvyUggpn9b7ir5dJXF/0vV6aESSqllkJsE1EJX8x0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hG307hoUIIqPzmQ4WMOeTdjKcsXppIilYZumiS9tjXr2NlcdYCqDGm8bz+KMHxbRK8sSzaDtInCYlR4CvxTGJQiIzEQwqntEXE6m4//dKozOFif2Tiib/rHqtb94Ckkhr7wP1NCVJHruzXlRxabsCfmTYNxVgrnLGwCS9T/L1fQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=PovcRIVX; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="PovcRIVX" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-493b61b52b6so15647435e9.1 for ; Thu, 09 Jul 2026 02:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783590589; x=1784195389; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MXemn+RWgfgniHXL+Z+iccp115cwF5wMpUS4nNjdkFs=; b=PovcRIVXEPSF/FJeQlxhlzoXjqZOrbs3CiE5bUYuum/kokSouOcrfuWzkJz+QZ+EEU bXZutBCPHghMPuDpORpgqEkhwf9ItYai/C2Wls7hXpV8JBACI0ISAzSZohMkmVLXApNn fZlxwp5LQbRlt1W9WkBqq04596J259cyQGkTEsx5D5ai1Vpe/8NCZrLqgzS5soekf8Zd N1CUWCeoaHYptaJl5ecJ1ZzDp9e7jZkz7Z27dZDIG4LQ8N1cI1J5HRitdDR0mFAuAiJK tCK2hnhPLuoPo29pU3Y3TxhIiW33KldSOjrnaQ78LbO8JgLXI4Yv8EB+9OvmBldN7dCE StRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783590589; x=1784195389; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MXemn+RWgfgniHXL+Z+iccp115cwF5wMpUS4nNjdkFs=; b=HzU+AR75no3HyhG+5F+UWpzo4sK+kXc5dRlXSDBg0t0CMUXnmsVmeuDVuVFqkfjAo5 bA4v7YlXkbMNGYIlsxImkfYYN3HvBpj+T8JcwTkWWaJmNBAX//8uym820bYz98cgjBrG 21c7ZuCOyq2TOwXcK9xt7Nl8ZjUboMLu5QBiKWYpu36yR9Du++LKi1j5hsjvmBLvd9Uy WYOd6Lucd7WKX51+4XM5u+3apgNEcl2RpYloq+vdZgthzetMLH5uR9mgPZG9Ifv/XO0C O+ueMMVGhsfSGP8UyCCeyUBoJglvUuXcXvfjQpkz++S2rqs/31ysEoC5kzx3x5dCDn9p IJ3Q== X-Forwarded-Encrypted: i=1; AHgh+Rpdp8r8cTNekRpMKMPyYN7ASMMnMnycoNhn+eL82MPhpXo8YphS36LBE33UF/AYCHzao0YfD5kt@vger.kernel.org X-Gm-Message-State: AOJu0YxAPs7yAWf+2366bn2IdJCRWtwTM2KZUxlerTLEvFs3n8WvuGYu nq19U2UBW8DP+2Lx8knV4VqB1N/omzGDqJujLcv7L+qwLjIe0Ese7uUnkG1Fa8wcTn0= X-Gm-Gg: AfdE7cky+mhdzOGQO1doL+puD6WaseQWi3gFkUnPQv54P0SvdmEk1ZlYDBqExzhvrNy WoAaQwDleG3lX9sj81JIwy4nti8EHByy9T/0ZabRFf5D52+fRV4rhCXEpKjHye7tqwYmhPrj4Zi 7rKbcsMmvHj20d0K5++Nnw9rQhf9rt1bL6uFj7BJsc8qFepkvDO8t9NbWXPX0TjQMalXv5SXAmR s91fYAYnMpgNYphYrYofTpN0ZsbO2tDmw18uF0mwtC0cQmzSpA4/dXwbwkOJ7xEAwf+4AFchCS2 O7w/dG8damJ4zzv8MdjKpRmZYK0Q7jac5qZBCaoNl4+73p4u1er/0Wi1NPEbSUdKPWMTrMytj+U JQ/G+tA0ApIZa3rPrN7a6aZD/PvefbzxfRsuhlQMu8MQVEclh1iyxF5EduAA4mJ6t/QMqWaq+rt zQ19hc928TI+fqz+DwrI9I+2LyGOSh2W+BSQ== X-Received: by 2002:a05:600c:c1d7:20b0:490:9782:3eb8 with SMTP id 5b1f17b1804b1-493e68c3535mr47652155e9.25.1783590588957; Thu, 09 Jul 2026 02:49:48 -0700 (PDT) Received: from [192.168.42.79] (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6d53absm47837275e9.6.2026.07.09.02.49.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 02:49:48 -0700 (PDT) Message-ID: <3e2ae6e8-41ad-45f0-a885-131a5711c276@suse.com> Date: Thu, 9 Jul 2026 11:49:45 +0200 Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] umh, treewide: Explicitly include linux/umh.h where needed To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Philipp Reisner , Lars Ellenberg , =?UTF-8?Q?Christoph_B=C3=B6hmwalder?= , Jens Axboe , Johan Hovold , Alex Elder , Greg Kroah-Hartman , "Rafael J. Wysocki" , Michal Januszewski , Helge Deller , Alexander Viro , Christian Brauner , Jan Kara , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Mark Fasheh , Joel Becker , Joseph Qi , Tejun Heo , Johannes Weiner , Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Pavel Machek , Len Brown , Andrew Morton , Danilo Krummrich , Nikolay Aleksandrov , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Howells , Jarkko Sakkinen , Paul Moore , James Morris , "Serge E. Hallyn" , Kentaro Takeda , Tetsuo Handa , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linux.dev, linux-block@vger.kernel.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, ocfs2-devel@lists.linux.dev, cgroups@vger.kernel.org, linux-modules@vger.kernel.org, linux-pm@vger.kernel.org, driver-core@lists.linux.dev, bridge@lists.linux.dev, netdev@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org References: <20260708154510.6794-1-petr.pavlu@suse.com> <20260708154510.6794-2-petr.pavlu@suse.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 7/8/26 8:13 PM, Michal Koutný wrote: > Hi Petr. > > On Wed, Jul 08, 2026 at 05:44:29PM +0200, Petr Pavlu wrote: >> diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c >> index a4337c9b5287..60eb994c32ae 100644 >> --- a/kernel/cgroup/cgroup-v1.c >> +++ b/kernel/cgroup/cgroup-v1.c >> @@ -16,6 +16,7 @@ >> #include >> #include >> #include >> +#include >> >> #include > > There is kmod.h in here too but it's unnecessary, no module lazy loading > in this code. You're right. I'll remove the kmod.h include from kernel/cgroup/cgroup-v1.c. I went through all the files again and it seems this was the only place I missed. -- Thanks, Petr