From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.219.43 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794956092; b=1rejmlfJ+y4HN2N+PyeY9IEW5tEdq6/YgBu4HJh04T5dvsNOUHh+rLVP7vX7zz+k7KHy nB+8XUponovs7vxUS3CWEUjuS+wnLiXs6fmhoqT7UkpIMiA7+l8bOO5FfeugjnHOD5iF1 czE9RBYXjzvx+oyC9uy7NXTXr8SfZ9uD60iet5oGBijErc2M/nFDCFo9qBuOpLvZwWDpm 6jlpmxWSeQvUJaVQoccek0zE9965IWcB0ed6iN5Ij0o7a9fKaGBR97Gj8o0MRN2wevm8I 9xgbFOU4tgG7rrUUS2g4CLM+X4ubFGXNaGFLS9kMCTk+eeOfySFhuI80t8cK3DHfGyA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794956092; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding: X-Mailer:From:To:Cc:Subject:References:In-Reply-To; bh=x7mnzARqVOnOj+KyQYPdVsGKtz9mrESSr8dwZPCPrb4=; b=IYxEPnC6nxOGi9uP6gUkEggMPWLzWDGXGvfV8FfR+kTEWjueSSV221YKou6a4vGx66EY lrTtmZ9G0zKOYhoWLf4PFc19DR6iN8thRdA1yfaf6l+rb8kMYNWi1/Dd8GZwjMXJ23Ze7 DQv5MhJD7rLfG56/Zlv2oPdgXkjxmJkNng6mvf+J5YPKxwG7EF1rfvfYaWaMuRZzlETj3 2uJfY7RzS3GkIElVIIzPYrwL5leKKfvscqPx1YpNtm1MYv8JvT12XPWH0YHah3+bnRovR x1md23mrnyZCd++UAkSSwYni5zLxnU8vfS6ksjVyKu7s7iTeai5Ak/n6igIw/OOsa8Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass header.d=paul-moore.com header.i=@paul-moore.com header.a=rsa-sha256 header.s=google header.b=UtNCGZpE; arc=none smtp.remote-ip=209.85.219.43 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0855B606A888 for ; Tue, 17 Nov 2026 22:54:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0855B606A888 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.a=rsa-sha256 header.s=google header.b=UtNCGZpE Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-91ec396c93dso3193166d6.1 for ; Tue, 17 Nov 2026 14:54:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1794956091; x=1795560891; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :content-type:mime-version:message-id:date:from:to:cc:subject:date :message-id:reply-to:content-type; bh=x7mnzARqVOnOj+KyQYPdVsGKtz9mrESSr8dwZPCPrb4=; b=UtNCGZpERg95VgV31TLB6SKqg3O5IY7S5liFSjgST8jxLuBTyzR7elX/LO4B+17kMt emUhFzAJ523PtXBWTKI4rJMkk8L8iAvXpxzY9TD8MMNsDMv1FPwo0jiVBLw0TxZJzSRm M5cRQRyRj7aHzh2YUb3Vb/bnEnakXFrgtav82xnixUcrNWbKQWH1k3udT/v1VIasKqLO uTKsS5k+9nPtBkkZasSNBsAuQHTcOe42csFt9XQI85jVgcm952Uo/h8/s94MGZwEY4QT dXQU1KnqOHAYC64PjxxQG6jfuYnQpsTsPvjaGwD16PnS2iNvHPZBi8Zn6I1XhQdylkcD T2kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794956091; x=1795560891; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :content-type:mime-version:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=x7mnzARqVOnOj+KyQYPdVsGKtz9mrESSr8dwZPCPrb4=; b=EiJmZ2mI1Mx8DnAhwftFyIhTZVcdcrTWcpfH6YfoVMuro6zWUjODWO9ZSbQX3XDJve W0VuMgH7gNQcigTiiIAtwkWqNdTN9NVdpaR6upsyShuLosjEWeUO80Ry/M/mg+rnIXZ3 c/RaQ6znle0c2rbGG8Yxf/6o/K4uaIstwUF3MAzP+1IKrBkC8bXh2doddgqbZXlTDEIX W3bSQ1xXJm71FJT/AG1ZPUQYnaWYsIhWr0qCawmEwk0fgoJREy5oV0XL26z1gciUbMbv AEZ7eCWJakt7J+7hg+qhd1GO1NkYgUH19fgTr7TCpEsfQFzIpWpE4UU+7nTmVqfBQSfC 6WSg== X-Forwarded-Encrypted: i=1; AL+hErFBly9+tsQnjxe7VxJMii0PG7rO5Ux6EVY92zjG4bY73yaCSjWTN7k1FA2K7yxOTQO2htxD1VhG@vger.kernel.org X-Gm-Message-State: APuU4Z/yWTBMwwCJuMgXWMHB6pA1I12cn7G+oWUZZ7PYURQfqn7Q9gnx 7QbV2nIr0JEZlLDOyGLXxOrRuyz44IrLu7v/h3D0Wn47GKMUJZ77gJXS0yHVlVzGNQ== X-Gm-Gg: AYBFou1S29ce0XlXLGna1ySYlS64bjc2Cqzf4J6ziqKPC7Wvfc8OtCrpNV5dl+GVpqh uIO1cs3SFTcP3Xp99+JNfeCR1PWHeqyN1P+f4KCv7qYcJX931cZyMPTGdjDu6S9ldWnPxKgelvw FW955pmv6NU86UVmReQw+BB1TsN5SECJ25v8nRSgxKBHEiPk0eDL+qqj0xKk55d84DvxLvrmscF fH8AUbWalwZnQc37cj6rHmuB6nzrKF6hsEpxnj7RWuaEDtp257Bk1wxs1x+n8cgOSncs4+Kqg6N k5LTPnxjE7rHCxkYc17EjXpGTzzlJxS0W/5KCcIbqm+D2DE9Pv//4A2doUJo9tOME9EdlD/h2sm 23KEuYaTjoB3APX7SLW7sA8laUhgqnXXl3n0cjVHcEP3zFcviARO3d7bHtM2tl+uOKWPed+3r29 fl/FsDD4NNYzOj94PXYzicAP70Bj3udXlgnYirPt1rSlPMjsAs5r4YJZ3KbIPky7QBp/ArlFsWD R2Ec+8Uhhm2VVsSo+9sjBU8tOArthDMIEHcYasfHrbe874pOv9rxSsDYiCg+HD5GWuhAs3lmvEy 6C9Tx7EKYDOG86Q7Y7x9SUwAkqndN8jGJiQeARCLXE+om6kDMhTYuKjwAX7nYa4fa8fCEN1dxIM WCYdfde3oYiBizIRhXI6pzKhuLcxrFKRgj0b9EM6lco2DADqo2Eo= X-Received: by 2002:a05:622a:1647:b0:535:92a6:22db with SMTP id d75a77b69052e-55d5a36e150mr14373911cf.1.1794956090990; Tue, 17 Nov 2026 14:54:50 -0800 (PST) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-55d58fea01dsm7818061cf.8.2026.11.17.14.54.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 14:54:49 -0800 (PST) Date: Tue, 17 Nov 2026 17:54:48 -0500 Message-ID: <44c0c45c0e2f47ed77bc45be47ebb3fb@paul-moore.com> X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20261117_1552/pstg-lib:20261117_1552/pstg-pwork:20261117_1552 From: Paul Moore To: Albert Esteve , Tejun Heo , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Jonathan Corbet , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Benjamin Gaignard , Brian Starkey , John Stultz , "T.J. Mercier" , Christian Brauner , James Morris , "Serge E. Hallyn" , Stephen Smalley , Shuah Khan , Randy Dunlap , =?UTF-8?B?T25kcmVqIE1vc27DocSNZWs=?= , Jens Wiklander , Sumit Garg , Philipp Stanner Cc: airlied@gmail.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org, op-tee@lists.trustedfirmware.org, Albert Esteve , echanude@redhat.com, mripard@kernel.org Subject: Re: [PATCH v5 4/8] lsm: Add memcg_charge_task LSM hook References: <20261117-v2_20230123_tjmercier_google_com-v5-4-1ce975f2a9ad@redhat.com> In-Reply-To: <20261117-v2_20230123_tjmercier_google_com-v5-4-1ce975f2a9ad@redhat.com> On Nov 17, 2026 Albert Esteve wrote: > > Both DMA_HEAP_IOCTL_ALLOC and the new DMA_BUF_IOCTL_XFER_CHARGE ioctl > accept a charge_fd field that, when set, causes the allocation to be > charged to an arbitrary process's cgroup rather than the caller's. > > Charging is currently limited to the caller's own memcg subtree unless > the caller holds CAP_SYS_RESOURCE. But the capability is all-or-nothing. > A process holding it, along with a dma-heap device node or a dma-buf > fd can charge unlimited memory to any other process's cgroup, potentially > exhausting that cgroup's limit and triggering OOM kills independent of > the victim's own activity or privileges. > > Add security_memcg_charge_task(), called in get_obj_cgroup_from_fd() > when charge_fd refers to another process. The hook receives > the credentials of the allocating process (from) and the credentials > of the process whose cgroup will be charged (to), giving security > modules a controlled enforcement point for cross-cgroup objcg > attribution policy. > > When CONFIG_SECURITY is not set the hook compiles to an inline > returning 0, adding no overhead to the fast path. > > Signed-off-by: Albert Esteve > --- > include/linux/lsm_hook_defs.h | 1 + > include/linux/security.h | 7 +++++++ > mm/memcontrol.c | 11 +++++++++++ > security/security.c | 15 +++++++++++++++ > 4 files changed, 34 insertions(+) ... > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 03cd90d5e623..2e6fcbe14d43 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -60,6 +60,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -3198,10 +3199,12 @@ static bool mem_cgroup_may_charge(struct mem_cgroup *memcg) > struct obj_cgroup *get_obj_cgroup_from_fd(int fd) > { > struct cgroup_subsys_state *css; > + const struct cred *tcred; > struct obj_cgroup *objcg; > struct mem_cgroup *memcg; > struct task_struct *task; > unsigned int pidfd_flags; > + int ret; > > if (mem_cgroup_disabled()) > return ERR_PTR(-EOPNOTSUPP); > @@ -3226,6 +3229,14 @@ struct obj_cgroup *get_obj_cgroup_from_fd(int fd) > if (IS_ERR(task)) > return ERR_CAST(task); > > + tcred = get_task_cred(task); > + ret = security_memcg_charge_task(current_cred(), tcred); Do you ever envision this "from" cred being something other than current_cred()? If the answer is "no", we might want to consider changing the LSM hook slightly to help prevent misuse in the future: int security_current_memcg_charge_task(const struct cred *tcred); > + put_cred(tcred); > + if (ret) { > + put_task_struct(task); > + return ERR_PTR(ret); > + } > + > rcu_read_lock(); > css = task_css(task, memory_cgrp_id); > put_task_struct(task); -- paul-moore.com