From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Subject: Re: [PATCH v8 4/6] cpuset: Make generate_sched_domains() recognize isolated_cpus Date: Mon, 28 May 2018 21:12:55 -0400 Message-ID: <45d70c88-e9f5-716a-ee9a-33dc111159cc@redhat.com> References: <1526590545-3350-1-git-send-email-longman@redhat.com> <1526590545-3350-5-git-send-email-longman@redhat.com> <20180524102837.GA3948@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180524102837.GA3948@localhost.localdomain> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Juri Lelli Cc: Tejun Heo , Li Zefan , Johannes Weiner , Peter Zijlstra , Ingo Molnar , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, Mike Galbraith , torvalds@linux-foundation.org, Roman Gushchin On 05/24/2018 06:28 AM, Juri Lelli wrote: > On 17/05/18 16:55, Waiman Long wrote: > > [...] > >> @@ -849,7 +860,12 @@ static void rebuild_sched_domains_locked(void) >> * passing doms with offlined cpu to partition_sched_domains(). >> * Anyways, hotplug work item will rebuild sched domains. >> */ >> - if (!cpumask_equal(top_cpuset.effective_cpus, cpu_active_mask)) >> + if (!top_cpuset.isolation_count && >> + !cpumask_equal(top_cpuset.effective_cpus, cpu_active_mask)) >> + goto out; >> + >> + if (top_cpuset.isolation_count && >> + !cpumask_subset(top_cpuset.effective_cpus, cpu_active_mask)) >> goto out; > Do we cover the case in which hotplug removed one of the isolated cpus > from cpu_active_mask? Yes, you are right. That is the remnant of my original patch that allows only one isolated_cpus at root. Thanks for spotting that. Cheers, Longman