From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBC6B303A26 for ; Mon, 23 Feb 2026 16:01:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771862469; cv=none; b=XdFnlzHlAS+8+OkBpRgOoMxjm2tycHGkKrN5BaJhSpszHHqKJNBM3j8uYfwMYfEzlscqnS+ivZ3No7PYfRZ6h8cET88ncqlLhSS9HGuriJL3kX2Ui/TJt0Z9GPoI8gYqBHF8tmO9oe99t4B9gJbJ954zhj/dENX5wg61kSWBoTA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771862469; c=relaxed/simple; bh=RBDa0jIO4VbsfMCQSIREc9cffsT7gvfxFla9G/UD7gs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TJB259nsy79sCeC4Kpe1Q8yT8PdtBjQ2SRFe0A9xfOZtW8K4+99p75YMxonJQLbSEplR4B91cBYXvMnQUfQfs8BzkUZ9Doudf6jhJPm6NLfgefyfISysOZaoKJtbVE8YjXbSSG29PbnXoDkfhPcvepxyt6bMahiOIVcf5S/R+g0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=PqHtQ0ke; arc=none smtp.client-ip=209.85.210.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="PqHtQ0ke" Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-7d18d02af68so3079372a34.2 for ; Mon, 23 Feb 2026 08:01:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1771862466; x=1772467266; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HX29uEwlmShEjfFqkdwl8Eb5l/ZDj+DL2kVuvz05S4k=; b=PqHtQ0kegO9Jus8W4cxNJI34/48vONyAjPHsLA84w3xhcTH+ehRGLWMutcJXZ2RAc/ sIIW38BVXjib20Hzzie5/NskGtknX8AWizrrYqFC+cHd9PikB2egS7JaNbi54oMe6P/4 ddf9EB7qZxkwqk3fcPIUygOni6aWtkYOvu4jDSCBwwynMsMsONTgNsrQ6SoIaPGchix5 apan0c7Jll92fM9SkRm6Fx8tqeLhj2uls5bV+0bT0tWyuhs39yMoF4q2AatkXEkfO9jQ WZmQcIv6TmU8UxJu44cTa6JGtGGdPs47Tmw+CdciuwJYkd046huqr3OenbIXyacOEqFB SY4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771862466; x=1772467266; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HX29uEwlmShEjfFqkdwl8Eb5l/ZDj+DL2kVuvz05S4k=; b=q8mNIqpOjrAzpcuHohcf3idNcYFxI6ZbnoQkFFwg7wF25/+LGxVkP9zijXmC95qTYx 1Zn0swjdq9bSRoqoAxQO/eP+YNQ4NAdxT045mp7HpvZSln14+MWKrturMI3evTFG1yfR 8HvEij9nD/vZ0hOMTGakQxMCpl8sziEm6UNSG0l+Nf65L1lkcKJy6LwsBpJaqnHHfXdy mOzenqytsOf6XXpim1cgHvmbsCqIAV8I5H/IYWXCB9MkeVTMN/yC4OwF52w4Yt+7LnCy 3SZHeEGMylUef8Y6bo7VzOmCaojgZa8iCdgdVQxOW6V1kaKc+iFk2WGjIcyKf/AgCiwP VQMQ== X-Forwarded-Encrypted: i=1; AJvYcCWOygfGfkFzH9rPBE0E2fdHIlfJoKHhJgOgNyLPyg6YrcQfwUXsH0t0N0WZmcNnyv6CPKL8eH+K@vger.kernel.org X-Gm-Message-State: AOJu0Yz5i1IeM/M4xskFYBRX50UArOg4FJekb5xpW/RwugPh+/cD7xFU JsH7teFF10kjsaJ90ltnb4y9h0adW3aRqeqR0f/VKEuLPyy69OQbEJs6UIR6oDUH/aw= X-Gm-Gg: AZuq6aJxnBAxEEBQGHI5/2EduK/u8is1hIhumqGZUZ9SvosJ2ZQVMUK+KS3nnw1ElUx 7Yi2UZ0m27SePvd6CB2WLo7/oidpd7vVqwwNAG94y6Wk1Q/NaskMj4xNGkevAS2bc1Rjghsu4fq WPyBFWDnr2ELDqnr5lpGViS6uicFjQVy9ESksVWFKFpOlp92aTCWzT650zRNYWPewekEWxTbj35 vXDFPVb6N5kuntKDrsVDApuEl6r5Yvkb4smzvWxnqt3Nj0DOhdjQiz+sfC6JhM0eCiGf9m8m5zq mJLWbqgEPSjHErk7zy6CHBiSW+gexvzvHnIWfWdSv5V8S1kd8+/s7ki/SwXlttfeTq7r4xxdIHE yu9JPmwwMgw7b4nM3/qBe9K0BsEHNCHXC+Mqk71CUEymQfY+onKNPMXPnmnEcQY40ZNSt0nJwBU 6tf3wH57tsERihhcldWQ1UuH8q/+xDpItiVYGKLuz/TDcbnCS96HTrWvzjzOriYiMiAyRMfaufA zTwZq3bLA== X-Received: by 2002:a05:6830:3153:b0:7d1:853c:83e3 with SMTP id 46e09a7af769-7d52bdf416bmr6177467a34.2.1771862465520; Mon, 23 Feb 2026 08:01:05 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:e37:2309:3937:4469? ([2600:8803:e7e4:500:e37:2309:3937:4469]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d55b9a8498sm1062950a34.28.2026.02.23.08.01.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Feb 2026 08:01:05 -0800 (PST) Message-ID: <47be2ff3-c25a-4aab-89fc-53921af8b0a9@baylibre.com> Date: Mon, 23 Feb 2026 10:01:03 -0600 Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/33] mm: vmstat: Prepare to protect against concurrent isolated cpuset change To: Frederic Weisbecker , LKML Cc: =?UTF-8?Q?Michal_Koutn=C3=BD?= , Andrew Morton , Bjorn Helgaas , Catalin Marinas , Chen Ridong , Danilo Krummrich , "David S . Miller" , Eric Dumazet , Gabriele Monaco , Greg Kroah-Hartman , Ingo Molnar , Jakub Kicinski , Jens Axboe , Johannes Weiner , Lai Jiangshan , Marco Crivellari , Michal Hocko , Muchun Song , Paolo Abeni , Peter Zijlstra , Phil Auld , "Rafael J . Wysocki" , Roman Gushchin , Shakeel Butt , Simon Horman , Tejun Heo , Thomas Gleixner , Vlastimil Babka , Waiman Long , Will Deacon , cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org References: <20260101221359.22298-1-frederic@kernel.org> <20260101221359.22298-5-frederic@kernel.org> Content-Language: en-US From: David Lechner In-Reply-To: <20260101221359.22298-5-frederic@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/1/26 4:13 PM, Frederic Weisbecker wrote: > The HK_TYPE_DOMAIN housekeeping cpumask will soon be made modifiable at > runtime. In order to synchronize against vmstat workqueue to make sure > that no asynchronous vmstat work is pending or executing on a newly made > isolated CPU, target and queue a vmstat work under the same RCU read > side critical section. > > Whenever housekeeping will update the HK_TYPE_DOMAIN cpumask, a vmstat > workqueue flush will also be issued in a further change to make sure > that no work remains pending after a CPU has been made isolated. > > Signed-off-by: Frederic Weisbecker > --- > mm/vmstat.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 65de88cdf40e..ed19c0d42de6 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -2144,11 +2144,13 @@ static void vmstat_shepherd(struct work_struct *w) > * infrastructure ever noticing. Skip regular flushing from vmstat_shepherd > * for all isolated CPUs to avoid interference with the isolated workload. > */ > - if (cpu_is_isolated(cpu)) > - continue; > + scoped_guard(rcu) { > + if (cpu_is_isolated(cpu)) > + continue; I think this might have introduced a bug - or at least an unintentional change in the program flow. scoped_guard() is implemented using a for loop. Now this continue statement will only exit the scoped_guard() scope rather than continuing the outer for loop. This means that cond_resched() will be called when it previously was not. > > - if (!delayed_work_pending(dw) && need_update(cpu)) > - queue_delayed_work_on(cpu, mm_percpu_wq, dw, 0); > + if (!delayed_work_pending(dw) && need_update(cpu)) > + queue_delayed_work_on(cpu, mm_percpu_wq, dw, 0); > + } > > cond_resched(); > }