Linux cgroups development
 help / color / mirror / Atom feed
From: Daniel Bristot de Oliveira <daolivei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Juri Lelli <juri.lelli-5wv7dgnIgG8@public.gmane.org>,
	Daniel Bristot de Oliveira
	<daolivei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Rik van Riel <riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Luis Claudio R. Goncalves"
	<lgoncalv-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cgroup: disable irqs while holding css_set_lock
Date: Tue, 7 Jun 2016 12:26:42 -0300	[thread overview]
Message-ID: <494c1f85-bbab-99f1-4095-914aaebdd708@redhat.com> (raw)
In-Reply-To: <20160607133009.GS9340@e106622-lin>

Ciao Juri,

On 06/07/2016 10:30 AM, Juri Lelli wrote:
> So, this and the partitioned one could actually overlap, since we don't
> set cpu_exclusive. Is that right?
> 
> I guess affinity mask of both m processes gets set correclty, but I'm
> not sure if we are missing one check in the admission control. Can you
> actually create two overlapping sets and get DEADLINE tasks running in
> them? For example, what happens if partitioned is [4] and clustered is
> [4-7]? Does setattr() fail?

That is what I was trying to understand/break. Fortunately, I still
can't break it! bravo! :-)

In the test you mentioned the task in the "clustered" fails to
sched_setattr().

Test output example:
+ '[' '!' -d partitioned ']'
+ mkdir partitioned
+ echo 4
+ echo 0
+ echo 0
+ echo 1155
+ cat /proc/self/cpuset
/partitioned
+ /root/m
main thread [1162]
deadline thread started [1164]
+ '[' '!' -d clustered ']'
+ mkdir clustered
+ echo 4-7
+ echo 0
+ echo 0
+ echo 1
+ echo 1155
+ cat /proc/self/cpuset
+ /root/m
/clustered
+ /root/m
main thread [1166]
sched_setattr: Operation not permitted

I will let you know if I find something odd.

-- Daniel

  reply	other threads:[~2016-06-07 15:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 22:24 [PATCH] cgroup: disable irqs while holding css_set_lock Daniel Bristot de Oliveira
     [not found] ` <aa70cd2645974808785960bfb0ddfebdec6e3095.1465243518.git.bristot-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-07 10:14   ` Juri Lelli
2016-06-07 12:39     ` Daniel Bristot de Oliveira
2016-06-07 13:30       ` Juri Lelli
2016-06-07 15:26         ` Daniel Bristot de Oliveira [this message]
     [not found]           ` <494c1f85-bbab-99f1-4095-914aaebdd708-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-07 16:11             ` Juri Lelli
2016-06-07 15:13 ` Daniel Bristot de Oliveira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=494c1f85-bbab-99f1-4095-914aaebdd708@redhat.com \
    --to=daolivei-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=juri.lelli-5wv7dgnIgG8@public.gmane.org \
    --cc=lgoncalv-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox