From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls Date: Wed, 14 Dec 2011 00:11:00 +0400 Message-ID: <4EE7B154.4050208@parallels.com> References: <1323676029-5890-1-git-send-email-glommer@parallels.com> <20111212.190734.1967808916779299221.davem@davemloft.net> <4EE757D7.6060006@uclouvain.be> <1323784748.2950.4.camel@edumazet-laptop> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1323784748.2950.4.camel@edumazet-laptop> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="utf-8"; format="flowed" To: Eric Dumazet Cc: christoph.paasch@uclouvain.be, David Miller , linux-kernel@vger.kernel.org, paul@paulmenage.org, lizf@cn.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com, ebiederm@xmission.com, gthelen@google.com, netdev@vger.kernel.org, linux-mm@kvack.org, kirill@shutemov.name, avagin@parallels.com, devel@openvz.org, cgroups@vger.kernel.org On 12/13/2011 05:59 PM, Eric Dumazet wrote: > Le mardi 13 d=C3=A9cembre 2011 =C3=A0 14:49 +0100, Christoph Paasch a= =C3=A9crit : > >> now there are plenty of compiler-warnings when CONFIG_CGROUPS is not= set: >> >> In file included from include/linux/tcp.h:211:0, >> from include/linux/ipv6.h:221, >> from include/net/ip_vs.h:23, >> from kernel/sysctl_binary.c:6: >> include/net/sock.h:67:57: warning: =E2=80=98struct cgroup_subsys=E2=80= =99 declared >> inside parameter list [enabled by default] >> include/net/sock.h:67:57: warning: its scope is only this definition= or >> declaration, which is probably not what you want [enabled by default= ] >> include/net/sock.h:67:57: warning: =E2=80=98struct cgroup=E2=80=99 d= eclared inside >> parameter list [enabled by default] >> include/net/sock.h:68:61: warning: =E2=80=98struct cgroup_subsys=E2=80= =99 declared >> inside parameter list [enabled by default] >> include/net/sock.h:68:61: warning: =E2=80=98struct cgroup=E2=80=99 d= eclared inside >> parameter list [enabled by default] >> >> >> Because struct cgroup is only declared if CONFIG_CGROUPS is enabled. >> (cfr. linux/cgroup.h) >> > > Yes, we probably need forward reference like this : > > Thanks ! > > [PATCH net-next] net: fix build error if CONFIG_CGROUPS=3Dn > > Reported-by: Christoph Paasch > Signed-off-by: Eric Dumazet I am deeply sorry about that. I was pretty sure I tested this case. But now that I looked into it, it= =20 occurs to me that I may have tested it only with the Memory Cgroup=20 disabled, not with the master flag off. Thanks for spotting this