From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [PATCH 1/2] cgroup: Remove unnecessary task_lock before fetching css_set on migration Date: Wed, 21 Dec 2011 09:53:08 +0800 Message-ID: <4EF13C04.2050006@cn.fujitsu.com> References: <1324320274-18485-1-git-send-email-msb@chromium.org> <1324407673-18975-1-git-send-email-fweisbec@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1324407673-18975-1-git-send-email-fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Frederic Weisbecker Cc: Containers , LKML , Oleg Nesterov , Mandeep Singh Baines , Tejun Heo , Cgroups , Andrew Morton , Paul Menage Frederic Weisbecker wrote: > When we fetch the css_set of the tasks on cgroup migration, we don't need > anymore to synchronize against cgroup_exit() that could swap the old one > with init_css_set. Now that we are using threadgroup_lock() during > the migrations, we don't need to worry about it anymore. > > Signed-off-by: Frederic Weisbecker Good catch! Reviewed-by: Li Zefan > Cc: Tejun Heo > Cc: Li Zefan > Cc: Containers > Cc: Cgroups > Cc: KAMEZAWA Hiroyuki > Cc: Oleg Nesterov > Cc: Andrew Morton > Cc: Paul Menage > Cc: Mandeep Singh Baines > --- > kernel/cgroup.c | 21 +++++++++++---------- > 1 files changed, 11 insertions(+), 10 deletions(-)