From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [PATCH 1/4] cgroup: remove redundant get/put of old css_set from migrate Date: Thu, 22 Dec 2011 13:11:56 +0800 Message-ID: <4EF2BC1C.90208@cn.fujitsu.com> References: <1324527518-24461-1-git-send-email-msb@chromium.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1324527518-24461-1-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Mandeep Singh Baines Cc: Tejun Heo , Frederic Weisbecker , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, KAMEZAWA Hiroyuki , Oleg Nesterov , Andrew Morton , Paul Menage Mandeep Singh Baines wrote: > We can now assume that the css_set reference held by the task > will not go away for an exiting task. PF_EXITING state can be > trusted throughout migration by checking it after locking > threadgroup. > > While at it, renamed css_set_check_fetched to css_set_fetched. > !css_set_fetched() seems to read better than > !css_set_check_fetched(). > > Changes in V4: > * https://lkml.org/lkml/2011/12/20/368 (Tejun Heo) > * Fix typo in commit message > * Undid the rename of css_set_check_fetched > * https://lkml.org/lkml/2011/12/20/427 (Li Zefan) > * Fix comment in cgroup_task_migrate() > Changes in V3: > * https://lkml.org/lkml/2011/12/20/255 (Frederic Weisbecker) > * Fixed to put error in retval > Changes in V2: > * https://lkml.org/lkml/2011/12/19/289 (Tejun Heo) > * Updated commit message > > Signed-off-by: Mandeep Singh Baines Reviewed-by: Li Zefan > Cc: Tejun Heo > Cc: Li Zefan > Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: KAMEZAWA Hiroyuki > Cc: Frederic Weisbecker > Cc: Oleg Nesterov > Cc: Andrew Morton > Cc: Paul Menage > --- > kernel/cgroup.c | 28 ++++++++-------------------- > 1 files changed, 8 insertions(+), 20 deletions(-)