cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] cgroup: move a check to parse_cgroupfs_options()
Date: Tue, 27 Dec 2011 09:48:57 +0800	[thread overview]
Message-ID: <4EF92409.3090404@cn.fujitsu.com> (raw)
In-Reply-To: <CAOS58YMffJ4uH02H0TH_DmhtjQOVgz2_u_6HJqsGnR6PQ3ZGzw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Tejun Heo wrote:
> Hello,
> 
> On Thu, Dec 22, 2011 at 7:40 PM, Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> wrote:
>>> And where did this one go?
>>
>> The other one I removed sets opts->new_root to NULL, and this one detects
>> the NULL ptr:
>>
>> if (!opts->subsys_bits && !opts->none)
>>        return NULL;
>> ...
>> opts->new_root = NULL;
>> ...
>> if (!opts->new_root)
>>        return -EINVAL;
>>
>> shortcut to:
>>
>> if (!opts->subsys_bits && !opts->none)
>>        return -EINVAL;
> 
> Thanks for the explanation. Maybe explaining it briefly in the commit
> message would be nice?
> 

I recalled why we have this check in this place, that is to allow mounting
by hierarchy name, but it has been broken for a long time. I'll send a
fix with detailed changelog.

      parent reply	other threads:[~2011-12-27  1:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-22  8:43 [PATCH] cgroup: move a check to parse_cgroupfs_options() Li Zefan
     [not found] ` <4EF2EDA7.4010004-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2011-12-22 15:20   ` Tejun Heo
     [not found]     ` <20111222152011.GA17084-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-23  3:40       ` Li Zefan
     [not found]         ` <4EF3F834.0-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2011-12-23 22:52           ` Tejun Heo
     [not found]             ` <CAOS58YMffJ4uH02H0TH_DmhtjQOVgz2_u_6HJqsGnR6PQ3ZGzw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-27  1:48               ` Li Zefan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF92409.3090404@cn.fujitsu.com \
    --to=lizf-bthxqxjhjhxqfuhtdcdx3a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).