cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC] splitting cgroup.c
Date: Thu, 19 Jan 2012 15:26:30 +0800	[thread overview]
Message-ID: <4F17C5A6.50501@cn.fujitsu.com> (raw)
In-Reply-To: <20120119022401.GH21533-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>

>> So I think for the sake of readability and maintainability, we'd
>> better split cgroup.c into smaller pieces:
> 
> I agree that splitting is necessary but IMHO splitting usually tends
> to go too far.  Maybe we can split it into two and think about further
> splitting later on?  e.g. internal logic vs. userland interfacing.
> 

This isn't feasible. The feasible way is to split by functionality,
which I think was the way taken by perf developers.

  parent reply	other threads:[~2012-01-19  7:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19  2:13 [RFC] splitting cgroup.c Li Zefan
     [not found] ` <4F177C67.6070907-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-01-19  2:24   ` Tejun Heo
     [not found]     ` <20120119022401.GH21533-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-01-19  7:26       ` Li Zefan [this message]
     [not found]         ` <4F17C5A6.50501-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-01-19 12:30           ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F17C5A6.50501@cn.fujitsu.com \
    --to=lizf-bthxqxjhjhxqfuhtdcdx3a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).