From mboxrd@z Thu Jan 1 00:00:00 1970 From: KAMEZAWA Hiroyuki Subject: Re: [RFC][PATCH 1/3] memcg: add methods to access pc->mem_cgroup Date: Wed, 21 Mar 2012 10:06:31 +0900 Message-ID: <4F692997.50901@jp.fujitsu.com> References: <4F66E6A5.10804@jp.fujitsu.com> <4F66E773.4000807@jp.fujitsu.com> <4F671138.3000508@parallels.com> <20120319153334.GC31213@tiehlicka.suse.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120319153334.GC31213-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Michal Hocko Cc: Glauber Costa , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Johannes Weiner , Hugh Dickins , Han Ying , "Aneesh Kumar K.V" , Andrew Morton , suleiman-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, n-horiguchi-PaJj6Psr51x8UrSeD/g0lQ@public.gmane.org, khlebnikov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, Tejun Heo (2012/03/20 0:33), Michal Hocko wrote: > On Mon 19-03-12 14:58:00, Glauber Costa wrote: >> On 03/19/2012 11:59 AM, KAMEZAWA Hiroyuki wrote: >>> In order to encode pc->mem_cgroup and pc->flags to be in a word, >>> access function to pc->mem_cgroup is required. >>> >>> This patch replaces access to pc->mem_cgroup with >>> pc_to_mem_cgroup(pc) : pc->mem_cgroup >>> pc_set_mem_cgroup(pc, memcg) : pc->mem_cgroup = memcg >>> >>> Following patch will remove pc->mem_cgroup. >>> >>> Signed-off-by: KAMEZAWA Hiroyuki >> Kame, >> >> I can't see a reason not to merge this patch right now, regardless of >> the other ones. > > I am not so sure about that. The patch doesn't do much on its own and > reference to the "following patch" might be confusing. Does it actually > help to rush it now? Hm. it sounds I should post full series (removing RFC) and finish page cgroup diet all ASAP. I'll continue updates and tests. Thanks, -Kame