From mboxrd@z Thu Jan 1 00:00:00 1970 From: KAMEZAWA Hiroyuki Subject: Re: [patch] mm: memcg: move pc lookup point to commit_charge() Date: Thu, 26 Apr 2012 11:02:02 +0900 Message-ID: <4F98AC9A.2080001@jp.fujitsu.com> References: <1335295860-28919-1-git-send-email-hannes@cmpxchg.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1335295860-28919-1-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Johannes Weiner Cc: Andrew Morton , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (2012/04/25 4:31), Johannes Weiner wrote: > None of the callsites actually need the page_cgroup descriptor > themselves, so just pass the page and do the look up in there. > > We already had two bugs (6568d4a 'mm: memcg: update the correct soft > limit tree during migration' and 'memcg: fix Bad page state after > replace_page_cache') where the passed page and pc were not referring > to the same page frame. > > Signed-off-by: Johannes Weiner > Acked-by: Hugh Dickins > Cc: KAMEZAWA Hiroyuki > Cc: Michal Hocko Acked-by: KAMEZAWA Hiroyuki