From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v2 02/29] slub: fix slab_state for slub Date: Thu, 17 May 2012 14:14:18 +0400 Message-ID: <4FB4CF7A.9090108@parallels.com> References: <1336758272-24284-1-git-send-email-glommer@parallels.com> <1336758272-24284-3-git-send-email-glommer@parallels.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: David Rientjes Cc: Pekka Enberg , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, KAMEZAWA Hiroyuki , Tejun Heo , Li Zefan , Greg Thelen , Suleiman Souhlal , Michal Hocko , Johannes Weiner , devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, Christoph Lameter On 05/16/2012 01:55 AM, David Rientjes wrote: > On Fri, 11 May 2012, Glauber Costa wrote: > >> When the slub code wants to know if the sysfs state has already been >> initialized, it tests for slab_state == SYSFS. This is quite fragile, >> since new state can be added in the future (it is, in fact, for >> memcg caches). This patch fixes this behavior so the test matches >>> = SYSFS, as all other state does. >> >> Signed-off-by: Glauber Costa > > Acked-by: David Rientjes > > Can be merged now, there's no dependency on the rest of this patchset. So, is anyone taking this? I plan another submission this week, let me know if I should include these two patches or not.