From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH] slab+slob: dup name string Date: Wed, 23 May 2012 19:15:52 +0400 Message-ID: <4FBCFF28.8080703@parallels.com> References: <1337613539-29108-1-git-send-email-glommer@parallels.com> <4FBBAE95.6080608@parallels.com> <1337773595.3013.15.camel@dabdike.int.hansenpartnership.com> <4FBCD328.6060406@parallels.com> <1337775878.3013.16.camel@dabdike.int.hansenpartnership.com> <4FBCFBE0.2080803@parallels.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Christoph Lameter Cc: James Bottomley , David Rientjes , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Pekka Enberg On 05/23/2012 07:17 PM, Christoph Lameter wrote: >> So if I understand it correctly, this is mostly because the name string >> > outlives the cache in the slub case, because of merging ? > Well this means we really only need the copying in slub which we already > have. > > The problem is that you want to make this behavior uniform over all > allocators so that you do not have to allocate the string on your own. > > Could you wait (and not rely on copying) until I am through with the > extraction project for common code for the allocators? At that point we > can resolve this issue consistently for all allocators. > Yes, I can. Let's just defer this for now.