From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kamezawa Hiroyuki Subject: Re: [PATCH 1/2] memcg: remove -EINTR at rmdir() Date: Tue, 19 Jun 2012 09:09:47 +0900 Message-ID: <4FDFC34B.3010003@jp.fujitsu.com> References: <4FDF17A3.9060202@jp.fujitsu.com> <20120618133012.GB2313@tiehlicka.suse.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120618133012.GB2313@tiehlicka.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Michal Hocko Cc: linux-mm , Linux Kernel Mailing List , cgroups@vger.kernel.org, Andrew Morton , Johannes Weiner (2012/06/18 22:30), Michal Hocko wrote: > On Mon 18-06-12 20:57:23, KAMEZAWA Hiroyuki wrote: >> 2 follow-up patches for "memcg: move charges to root cgroup if use_hierarchy=0", >> developped/tested onto memcg-devel tree. Maybe no HUNK with -next and -mm.... >> -Kame >> == >> memcg: remove -EINTR at rmdir() >> >> By commit "memcg: move charges to root cgroup if use_hierarchy=0", >> no memory reclaiming will occur at removing memory cgroup. > > OK, so the there are only 2 reasons why move_parent could fail in this > path. 1) it races with somebody else who is uncharging or moving the > charge and 2) THP split. > 1) works for us and 2) doens't seem to be serious enough to expect that > it would stall rmdir on the group for unbound amount of time so the > change is safe (can we make this into the changelog please?). > Yes. But the failure of move_parent() (-EBUSY) will be retried. Remaining problems are - attaching task while pre_destroy() is called. - creating child cgroup while pre_destroy() is called. I think I need to make a patch for cgroup layer as I previously posted. I'd like to try again. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org