cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sha Zhengju <handai.szj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Kamezawa Hiroyuki
	<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	mhocko-AlSwsSmVLrQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Sha Zhengju <handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 7/7] memcg: print more detailed info while memcg oom happening
Date: Wed, 04 Jul 2012 19:20:49 +0800	[thread overview]
Message-ID: <4FF42711.50303@gmail.com> (raw)
In-Reply-To: <4FF3FED6.9010700-+CUm20s59erQFUHtdCDX3A@public.gmane.org>

On 07/04/2012 04:29 PM, Kamezawa Hiroyuki wrote:
> (2012/06/28 20:06), Sha Zhengju wrote:
>> From: Sha Zhengju <handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
>>
>> While memcg oom happening, the dump info is limited, so add this
>> to provide memcg page stat.
>>
>> Signed-off-by: Sha Zhengju <handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
> Could you split this into a different series ?
> seems good to me in general but...one concern is hierarchy handling.
>
> IIUC, the passed 'memcg' is the root of hierarchy which gets OOM.
> So, the LRU info, which is local to the root memcg, may not contain any good
> information. I think you should visit all memcg under the tree.
>
Yes, you're right!
I did not handle hierarchy here, and just now I make a test case to
prove this.
I'll split it to another series later.

Thanks for reviewing!


Thanks,
Sha

  parent reply	other threads:[~2012-07-04 11:20 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 10:54 [PATCH 0/7] Per-cgroup page stat accounting Sha Zhengju
2012-06-28 10:58 ` [PATCH 2/7] memcg: remove MEMCG_NR_FILE_MAPPED Sha Zhengju
     [not found]   ` <1340881111-5576-1-git-send-email-handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
2012-07-02 10:44     ` Kamezawa Hiroyuki
2012-07-04 12:56   ` Michal Hocko
     [not found]     ` <20120704125608.GF29842-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-07-04 12:58       ` Michal Hocko
2012-07-07 13:48   ` Fengguang Wu
2012-07-09 21:01   ` Greg Thelen
2012-07-11  8:00     ` Sha Zhengju
2012-06-28 11:01 ` [PATCH 3/7] Make TestSetPageDirty and dirty page accounting in one func Sha Zhengju
     [not found]   ` <1340881275-5651-1-git-send-email-handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
2012-07-02 11:14     ` Kamezawa Hiroyuki
2012-07-07 14:42       ` Fengguang Wu
2012-07-04 14:23   ` Michal Hocko
     [not found] ` <1340880885-5427-1-git-send-email-handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
2012-06-28 10:57   ` [PATCH 1/7] memcg: update cgroup memory document Sha Zhengju
2012-07-02  7:00     ` Kamezawa Hiroyuki
     [not found]     ` <1340881055-5511-1-git-send-email-handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
2012-07-04 12:47       ` Michal Hocko
2012-07-07 13:45       ` Fengguang Wu
2012-06-28 11:03   ` [PATCH 4/7] Use vfs __set_page_dirty interface instead of doing it inside filesystem Sha Zhengju
     [not found]     ` <1340881423-5703-1-git-send-email-handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
2012-06-29  5:21       ` Sage Weil
2012-07-02  8:10         ` Sha Zhengju
2012-07-02 14:49           ` Sage Weil
2012-07-04  8:11             ` Sha Zhengju
2012-07-05 15:20               ` Sage Weil
2012-07-05 15:40                 ` Sha Zhengju
2012-07-04 14:27     ` Michal Hocko
2012-06-28 11:04   ` [PATCH 5/7] memcg: add per cgroup dirty pages accounting Sha Zhengju
2012-07-03  5:57     ` Kamezawa Hiroyuki
2012-07-08 14:45       ` Fengguang Wu
     [not found]     ` <1340881486-5770-1-git-send-email-handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
2012-07-04 16:11       ` Michal Hocko
2012-07-09 21:02     ` Greg Thelen
2012-07-11  9:32       ` Sha Zhengju
     [not found]         ` <4FFD4822.4020300-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-07-19  6:33           ` Kamezawa Hiroyuki
2012-06-28 11:06   ` [PATCH 6/7] memcg: add per cgroup writeback " Sha Zhengju
     [not found]     ` <1340881562-5900-1-git-send-email-handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
2012-07-08 14:53       ` Fengguang Wu
2012-07-09  3:36         ` Sha Zhengju
     [not found]           ` <4FFA51AB.30203-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-07-09  4:14             ` Fengguang Wu
2012-07-09  4:18               ` Kamezawa Hiroyuki
     [not found]                 ` <4FFA5B7F.8030403-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-07-09  5:22                   ` Sha Zhengju
     [not found]                     ` <4FFA6AAE.8030700-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-07-09  5:28                       ` Fengguang Wu
2012-07-09  5:19               ` Sha Zhengju
2012-07-09  5:25                 ` Fengguang Wu
2012-07-09 21:02     ` Greg Thelen
2012-06-28 11:06   ` [PATCH 7/7] memcg: print more detailed info while memcg oom happening Sha Zhengju
     [not found]     ` <1340881609-5935-1-git-send-email-handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
2012-07-04  8:25       ` Sha Zhengju
2012-07-04  8:29     ` Kamezawa Hiroyuki
     [not found]       ` <4FF3FED6.9010700-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-07-04 11:20         ` Sha Zhengju [this message]
2012-06-28 11:05 ` [PATCH 6/7] memcg: add per cgroup writeback pages accounting Sha Zhengju
2012-07-03  6:31   ` Kamezawa Hiroyuki
2012-07-04  8:24     ` Sha Zhengju
2012-07-08 14:44     ` Fengguang Wu
2012-07-08 23:01       ` Johannes Weiner
     [not found]         ` <20120708230100.GA5340-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-07-09  1:37           ` Fengguang Wu
2012-07-04 16:15   ` Michal Hocko
2012-06-29  8:23 ` [PATCH 0/7] Per-cgroup page stat accounting Kamezawa Hiroyuki
     [not found]   ` <4FED6604.9080603-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-07-02  7:51     ` Sha Zhengju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF42711.50303@gmail.com \
    --to=handai.szj-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org \
    --cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
    --cc=yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).