cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sha Zhengju <handai.szj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: David Rientjes <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	KAMEZAWA Hiroyuki
	<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
	Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	KOSAKI Motohiro
	<kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
	Minchan Kim <minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch 2/5] mm, oom: introduce helper function to process threads during scan
Date: Thu, 12 Jul 2012 15:18:21 +0800	[thread overview]
Message-ID: <4FFE7A3D.3010908@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206291405360.6040-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>

On 06/30/2012 05:06 AM, David Rientjes wrote:
> This patch introduces a helper function to process each thread during the
> iteration over the tasklist.  A new return type, enum oom_scan_t, is
> defined to determine the future behavior of the iteration:
>
>   - OOM_SCAN_OK: continue scanning the thread and find its badness,
>
>   - OOM_SCAN_CONTINUE: do not consider this thread for oom kill, it's
>     ineligible,
>
>   - OOM_SCAN_ABORT: abort the iteration and return, or
>
>   - OOM_SCAN_SELECT: always select this thread with the highest badness
>     possible.
>
> There is no functional change with this patch.  This new helper function
> will be used in the next patch in the memory controller.
>

Looks good to me.
You can add  Reviewed-by: Sha Zhengju <handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org> :-)


Thanks,
Sha

  parent reply	other threads:[~2012-07-12  7:18 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26  1:47 [patch 1/3] mm, oom: move declaration for mem_cgroup_out_of_memory to oom.h David Rientjes
2012-06-26  3:12 ` Kamezawa Hiroyuki
     [not found]   ` <4FE9289B.2050105-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-06-26  6:04     ` KOSAKI Motohiro
     [not found] ` <alpine.DEB.2.00.1206251846020.24838-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-06-26  1:47   ` [rfc][patch 2/3] mm, oom: introduce helper function to process threads during scan David Rientjes
     [not found]     ` <alpine.DEB.2.00.1206251846450.24838-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-06-26  3:22       ` Kamezawa Hiroyuki
2012-06-26  6:05         ` KOSAKI Motohiro
2012-06-26  8:48       ` Michal Hocko
2012-06-26  1:47   ` [rfc][patch 3/3] mm, memcg: introduce own oom handler to iterate only over its own threads David Rientjes
     [not found]     ` <alpine.DEB.2.00.1206251847180.24838-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-06-26  5:32       ` Kamezawa Hiroyuki
2012-06-26 20:38         ` David Rientjes
     [not found]           ` <alpine.DEB.2.00.1206261323260.8673-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-06-27  5:35             ` David Rientjes
     [not found]               ` <alpine.DEB.2.00.1206262229380.32567-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-06-28  1:43                 ` David Rientjes
2012-06-28 17:16                   ` Oleg Nesterov
2012-06-29 20:37                     ` David Rientjes
2012-06-28  8:55                 ` Kamezawa Hiroyuki
     [not found]                   ` <4FEC1C06.70802-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-06-29 20:30                     ` David Rientjes
2012-07-03 17:56                       ` Oleg Nesterov
2012-06-28  8:52           ` Kamezawa Hiroyuki
2012-06-26  9:58       ` Michal Hocko
2012-06-26  8:34   ` [patch 1/3] mm, oom: move declaration for mem_cgroup_out_of_memory to oom.h Michal Hocko
2012-06-29 21:06 ` [patch 1/5] " David Rientjes
2012-06-29 21:06   ` [patch 4/5] mm, oom: reduce dependency on tasklist_lock David Rientjes
     [not found]     ` <alpine.DEB.2.00.1206291406110.6040-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-07-03 18:17       ` Oleg Nesterov
2012-07-10 21:04         ` David Rientjes
2012-07-13 14:32       ` Michal Hocko
     [not found]         ` <20120713143206.GA4511-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-07-16  7:42           ` [PATCH mmotm] mm, oom: reduce dependency on tasklist_lock: fix Hugh Dickins
     [not found]             ` <alpine.LSU.2.00.1207160039120.3936-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2012-07-16  8:06               ` Michal Hocko
2012-07-16  9:01                 ` Hugh Dickins
2012-07-16  9:27                   ` Michal Hocko
2012-07-19 10:11               ` Kamezawa Hiroyuki
     [not found]   ` <alpine.DEB.2.00.1206291404530.6040-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-06-29 21:06     ` [patch 2/5] mm, oom: introduce helper function to process threads during scan David Rientjes
     [not found]       ` <alpine.DEB.2.00.1206291405360.6040-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-07-12  7:18         ` Sha Zhengju [this message]
2012-06-29 21:06     ` [patch 3/5] mm, memcg: introduce own oom handler to iterate only over its own threads David Rientjes
     [not found]       ` <alpine.DEB.2.00.1206291405500.6040-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-07-10 21:19         ` Andrew Morton
2012-07-10 23:24           ` David Rientjes
2012-07-12 14:50         ` Sha Zhengju
2012-06-29 21:07     ` [patch 5/5] mm, memcg: move all oom handling to memcontrol.c David Rientjes
     [not found]       ` <alpine.DEB.2.00.1206291406270.6040-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-07-04  5:51         ` Kamezawa Hiroyuki
2012-07-13 14:34       ` Michal Hocko
2012-07-10 21:05     ` [patch 1/5] mm, oom: move declaration for mem_cgroup_out_of_memory to oom.h David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFE7A3D.3010908@gmail.com \
    --to=handai.szj-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
    --cc=kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
    --cc=minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).