From mboxrd@z Thu Jan 1 00:00:00 1970 From: brookxu Subject: Re: [PATCH v2] misc_cgroup: use a counter to count the number of failures Date: Thu, 26 Aug 2021 09:34:45 +0800 Message-ID: <4ed67493-e595-e002-69f9-1f53662ba189@gmail.com> References: <20210824164423.GA11859@blackbody.suse.cz> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Tp+HuDAKrxLDg/2YbkAeAyqQwvPdfQEmonlSS0UrGxo=; b=ZuvSEK/4HcZ8UVE3rknY0O62RhjbNmlM4gEgBj2bbfUbVSAoMuvtM97YrfYp3qe1lN 6E9hgnUnwNPHeFXaq1qXa0leSC5VMhIMRrTtqpLPot4dWLngA8rR+yOJQoDhYBm+yGaM ljoO9lXixo7H1kxUgZoluJtxxSEYWFe/Qyknei+Jr450NjXggnqDeXaZYMfefLxwPRhJ uAsBKBpVzkP4ZTxyIBlkNTDVcXoBG6Q70u18czI80t+OIvbvlNwktNg22ACKBPNGgvHv +l4ot/+eqqtyz65V4BsUeD67OCbPMBQz6wc0eUoS3mG9ghSwU7xRuJ2WGdSix+2lDRYf E8Xg== In-Reply-To: Content-Language: en-US List-ID: Content-Type: text/plain; charset="iso-8859-1" To: Tejun Heo , =?UTF-8?Q?Michal_Koutn=c3=bd?= Cc: lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, vipinsh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Tejun Heo wrote on 2021/8/25 3:08: > Hello, >=20 > On Tue, Aug 24, 2021 at 06:44:23PM +0200, Michal Koutn=C3=BD wrote: >> However, the non-hierarchical failcnt interface looks like v1ism to me >> (I think new features should come with v2 first in mind). >> What about exposing this in misc.events file with max.$res_name entries?= =20 >=20 > Ah yeah, good point. misc.events sounds like a good spot to put these. >=20 >> Or if the hierarchical reporting is unnecessary now, there can be just >> misc.events.local for starters. >=20 > I'd prefer to stick with hierarchical counting as the first step at least. >=20 >> (That reminds me the forgotten pids.events[.local] rework [1], oops.) >> >> https://lore.kernel.org/lkml/20191128172612.10259-1-mkoutny-IBi9RG/b67k@= public.gmane.org/#t The core logic of pids cgroup and misc cgroup is similar. Is it possible for us to merge pids cgroup into misc cgroup? > I think both counters are useful - the number of failures due to this type > of limit in this subhierarchy, and the number of failures caused by this > particular limit in this subhierarchy. It's a pretty subtle difference to > encapsulate in a counter name tho. >=20 > Thanks. >=20