From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 160C91C860C for ; Mon, 13 Jul 2026 12:34:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783946091; cv=none; b=OI0xbr+Bx5LOkZtYpijPNIwbx8hxIp1pRs74sr9rqSBoAQhGPjlzbHOrcL7nD3yaZK7iNH7ZHrjKprUGOVsJGxgEEr5LCWT4exOl0kQj29/jz1AezbKk35N0EIalEtneM0LA3zA37L67CvPV6B5JCqNpTUcgk4gYOo30cs+pWLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783946091; c=relaxed/simple; bh=U5MfuI69Ft1hR5jqHeDoj3qJTcgQ5f4Qpk1xwWp59hI=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=IUIXXva41JyNdJ80fyfwJMLbGWN/Mw2Q2HZxwPvj2OeDugE+Y/M9m76GfMVcIbM320sDhJric2f/JIZBvxIItjSBiw+Qjd6dDPw1uh4aI/zd2pDzfDEPofONnoEe+UMXz451naLrA1WBrtHczbyT036fflA9UFKmY481jtza4wU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=XqnxdyNS; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="XqnxdyNS" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783946087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oBpjdqtbb2rhGpETSozc/NsckdAfaonoUVSLNlrevv0=; b=XqnxdyNSZIzgO8zwA2kFyBgmgkh2Jcw+ncWitZMoz3Kw0IQLXn+O2Kxb0/6pD5GPT+lROt jnJ63+rKvyE7k0cLuTpcwGZUw+3gYRhEkWVVz7qfhSEFnPT+XdPxF9pt59LBblAkqiKkjT T1Zf0m79HVLADdHQMtAbfzDk0vsIvTw= Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH] mm: memcontrol: factor out memcg kmem uncharge sequence X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20260713090304.3015329-1-guopeng.zhang@linux.dev> Date: Mon, 13 Jul 2026 20:33:54 +0800 Cc: Andrew Morton , Roman Gushchin , Johannes Weiner , Michal Hocko , Shakeel Butt , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Guopeng Zhang Content-Transfer-Encoding: 7bit Message-Id: <5012E3D9-0989-4115-A17B-FE0050DFE25F@linux.dev> References: <20260713090304.3015329-1-guopeng.zhang@linux.dev> To: Guopeng Zhang X-Migadu-Flow: FLOW_OUT > On Jul 13, 2026, at 17:03, Guopeng Zhang wrote: > > From: Guopeng Zhang > > The kmem-uncharge sequence (mod_memcg_state(MEMCG_KMEM) + > memcg1_account_kmem + conditional memcg_uncharge) is duplicated verbatim > in obj_cgroup_release() and drain_obj_stock_slot(). Factor it into a > small memcg_uncharge_kmem() helper. The reference get/put stays at the > call sites, as they differ. > > No functional change. > > Signed-off-by: Guopeng Zhang Reviewed-by: Muchun Song