From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v2 04/11] kmem accounting basic infrastructure Date: Wed, 15 Aug 2012 17:04:31 +0400 Message-ID: <502B9E5F.2080907@parallels.com> References: <1344517279-30646-1-git-send-email-glommer@parallels.com> <1344517279-30646-5-git-send-email-glommer@parallels.com> <20120814162144.GC6905@dhcp22.suse.cz> <502B6D03.1080804@parallels.com> <20120815123931.GF23985@dhcp22.suse.cz> <502B9BD4.4070003@parallels.com> <20120815130228.GH23985@dhcp22.suse.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120815130228.GH23985-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Michal Hocko Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, Johannes Weiner , Andrew Morton , kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, Christoph Lameter , David Rientjes , Pekka Enberg On 08/15/2012 05:02 PM, Michal Hocko wrote: > On Wed 15-08-12 16:53:40, Glauber Costa wrote: > [...] >>>>> This doesn't check for the hierachy so kmem_accounted might not be in >>>>> sync with it's parents. mem_cgroup_create (below) needs to copy >>>>> kmem_accounted down from the parent and the above needs to check if this >>>>> is a similar dance like mem_cgroup_oom_control_write. >>>>> >>>> >>>> I don't see why we have to. >>>> >>>> I believe in a A/B/C hierarchy, C should be perfectly able to set a >>>> different limit than its parents. Note that this is not a boolean. >>> >>> Ohh, I wasn't clear enough. I am not against setting the _limit_ I just >>> meant that the kmem_accounted should be consistent within the hierarchy. >>> >> >> If a parent of yours is accounted, you get accounted as well. This is >> not the state in this patch, but gets added later. Isn't this enough ? > > But if the parent is not accounted, you can set the children to be > accounted, right? Or maybe this is changed later in the series? I didn't > get to the end yet. > Yes, you can. Do you see any problem with that?