public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
To: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	Dave Jones <davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>,
	Peter Zijlstra
	<a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org>,
	Paul Turner <pjt-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Lennart Poettering
	<lennart-mdGvqq1h2p+GdvJs77BJ7Q@public.gmane.org>,
	Kay Sievers <kay.sievers-tD+1rO4QERM@public.gmane.org>,
	Kamezawa Hiroyuki
	<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2] memcg: first step towards hierarchical controller
Date: Tue, 4 Sep 2012 17:27:20 +0400	[thread overview]
Message-ID: <504601B8.2050907@parallels.com> (raw)
In-Reply-To: <20120904130905.GA15683-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>

On 09/04/2012 05:09 PM, Michal Hocko wrote:
> Not really. Do it slowly means that somebody actually _notices_ that
> something is about to change and they have a lot of time for that. This
> will be really hard with the config option saying N by default.  People
> will ignore that until it's too late.
> We are interested in those users who would keep the config default N and
> they are (ab)using use_hierarchy=0 in a way which is hard/impossible to
> fix. This is where distributions might help and they should IMHO but why
> to put an additional code into upstream? Isn't it sufficient that those
> who would like to help (and take the risk) would just take the patch?

At least Fedora, seem to frown upon heavily at non-upstream patches.
To follow up with what you say, what would you say if we would WARN_ON()
unconditionally even if this switch is turned off?

a warn on dmesg is almost impossible not to be seen by anyone who cares.
That warning would tell people to flip the Kconfig option for the
warning will disappear. But ultimately, we are still keeping the
behavior intact.

  parent reply	other threads:[~2012-09-04 13:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-03 15:46 [PATCH v2] memcg: first step towards hierarchical controller Glauber Costa
     [not found] ` <1346687211-31848-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-03 16:41   ` Ben Hutchings
     [not found]     ` <20120903164148.GS29217-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2012-09-04  8:29       ` Glauber Costa
2012-09-03 17:08 ` Michal Hocko
2012-09-04  8:34   ` Glauber Costa
     [not found]     ` <5045BD25.10301-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-04 13:09       ` Michal Hocko
     [not found]         ` <20120904130905.GA15683-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-04 13:27           ` Glauber Costa [this message]
2012-09-04 14:35             ` Michal Hocko
2012-09-04 14:37               ` Glauber Costa
     [not found]                 ` <50461241.5010300-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-04 14:54                   ` Michal Hocko
     [not found]                     ` <20120904145414.GC15683-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-04 14:54                       ` Glauber Costa
     [not found]                         ` <50461610.30305-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-04 16:25                           ` Michal Hocko
     [not found]                             ` <20120904162501.GE15683-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-05  8:14                               ` Glauber Costa
     [not found]                                 ` <504709D4.2010800-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-05 14:49                                   ` Michal Hocko
     [not found]                                     ` <20120905144942.GH5388-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-05 20:12                                       ` Tejun Heo
     [not found]                                         ` <20120905201238.GE13737-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-06 12:06                                           ` Michal Hocko
2012-09-06 12:09                                             ` Glauber Costa
     [not found]                                               ` <50489270.7060108-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-06 12:18                                                 ` Michal Hocko
     [not found]                                                   ` <20120906121842.GG22426-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-07  9:45                                                     ` Glauber Costa
     [not found]               ` <20120904143552.GB15683-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-04 18:22                 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504601B8.2050907@parallels.com \
    --to=glommer-bzqdu9zft3wakbo8gow8eq@public.gmane.org \
    --cc=a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org \
    --cc=ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
    --cc=kay.sievers-tD+1rO4QERM@public.gmane.org \
    --cc=lennart-mdGvqq1h2p+GdvJs77BJ7Q@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
    --cc=pjt-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox