Re: [PATCH] memcg: fix hotplugged memory zone oops

Hugh Dickins
2012-11-02T23:31:18Z

On Fri, 2 Nov 2012, Michal Hocko wrote:
>
> OK, it adds "an overhead" also when there is no hotadd going on but this
> is just one additional mem access&cmp&je so it shouldn't be noticable
> (lruvec->zone is used most of the time later so it not a pointless
> load).

I think so too.

> It is also easier to backport for stable.

Yes.

> But is there any reason to fix it later properly in the hotadd hook?

I don't know. Not everybody liked it fixed this way: it's not
unreasonable to see this as a quick hack rather than the right fix.

I was expecting objectors to post alternative hotadd hook patches,
then we could compare and decide. That didn't happen; but we can
certainly look to taking out these lines later if something we
agree is better comes along. Not high on anyone's agenda, I think.

>
> Anyway
> Acked-by: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>

Thanks,
Hugh