From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCHSET] cgroup: simplify cgroup removal path Date: Wed, 31 Oct 2012 21:24:06 +0400 Message-ID: <50915EB6.3060704@parallels.com> References: <1351657365-25055-1-git-send-email-tj@kernel.org> <50912C6D.6020000@parallels.com> <20121031171849.GH2945@htj.dyndns.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121031171849.GH2945-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Tejun Heo Cc: lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 10/31/2012 09:18 PM, Tejun Heo wrote: > Hello, > > On Wed, Oct 31, 2012 at 05:49:33PM +0400, Glauber Costa wrote: >> The only think that drew my attention is that you are changing the >> local_irq_save callsite to local_irq_disable. It shouldn't be a problem, >> since this is never expected to be called in interrupt context. >> >> Still... it makes me wonder if that disabled-interrupt block is still >> needed? According to the changelogs, it was introduced in e7c5ec919 for >> the css_tryget mechanism. But css_tryget itself will never scan >> subsystems, so if we can no longer fail, we should be able to just ditch >> it. Unless I am missing something > > Note both in the commit messages. > I am sorry, but I can't find anything that may be related to this in the commit messages. Can you be more specific ?