From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [PATCHSET cgroup/for-3.8] cgroup: allow ->post_create() to fail Date: Mon, 19 Nov 2012 16:54:11 +0800 Message-ID: <50A9F3B3.2010607@huawei.com> References: <1352775704-9023-1-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1352775704-9023-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Tejun Heo Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org On 2012/11/13 11:01, Tejun Heo wrote: > Hello, > > This became a rather large patchset mostly because there are a lot of > weirdities and subtle breakages in create/destroy/load/unload paths. > The goal of the patchset is allowing ->post_create() to fail and > renaming ->create/post_create/pre_destroy/destroy() to > ->css_alloc/css_online/css_offline/css_free(). > > This patchset contains the following seventeen patches. > > 0001-cgroup-remove-incorrect-dget-dput-pair-in-cgroup_cre.patch > 0002-cgroup-initialize-cgrp-allcg_node-in-init_cgroup_hou.patch > 0003-cgroup-open-code-cgroup_create_dir.patch > 0004-cgroup-create-directory-before-linking-while-creatin.patch > 0005-cgroup-cgroup-dentry-isn-t-a-RCU-pointer.patch > 0006-cgroup-remove-duplicate-RCU-free-on-struct-cgroup.patch > 0007-cgroup-make-CSS_-flags-bit-masks-instead-of-bit-posi.patch > 0008-cgroup-trivial-cleanup-for-cgroup_init-load_subsys.patch > 0009-cgroup-lock-cgroup_mutex-in-cgroup_init_subsys.patch > 0010-cgroup-fix-harmless-bugs-in-cgroup_load_subsys-fail-.patch > 0011-cgroup-separate-out-cgroup_destroy_locked.patch > 0012-cgroup-introduce-CSS_ONLINE-flag-and-on-offline_css-.patch > 0013-cgroup-simplify-cgroup_load_subsys-failure-path.patch > 0014-cgroup-use-mutex_trylock-when-grabbing-i_mutex-of-a-.patch > 0015-cgroup-update-cgroup_create-failure-path.patch > 0016-cgroup-allow-post_create-to-fail.patch > 0017-cgroup-rename-create-post_create-pre_destroy-destroy.patch > Acked-by: Li Zefan except 0006-cgroup-remove-duplicate-RCU-free-on-struct-cgroup.patch > 0001 is a bugfix. Tagged for -stable. I don't I'll push it through > for-3.7-fixes tho. This has been broken forever and nobody reported > anything yet. > > 0002-0011 are various fixes and cleanups to prepare for the following > changes. Each should be self-explanatory. > > 0012-0015 are preparation patches more directly related to allowing > failure of ->post_create(). > > 0016 allows ->post_create() to fail. > > 0017 renames ops and updates documentation. > > This patchst is on top of cgroup/for-3.8 and available on the > following git branch. > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-cgroup-online-may-fail