From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Wagner Subject: Re: [PATCH 3/3] netcls_cgroup: implement proper hierarchy support Date: Mon, 19 Nov 2012 14:47:06 +0100 Message-ID: <50AA385A.90503@monom.org> References: <1353123062-23193-1-git-send-email-tj@kernel.org> <1353123062-23193-4-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1353123062-23193-4-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Tejun Heo Cc: nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, tgraf-G/eBtMaohhA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org Hi Tejun, On 17.11.2012 04:31, Tejun Heo wrote: > @@ -112,15 +161,6 @@ struct cgroup_subsys net_cls_subsys = { > .subsys_id = net_cls_subsys_id, > .base_cftypes = ss_files, > .module = THIS_MODULE, > - > - /* > - * While net_cls cgroup has the rudimentary hierarchy support of > - * inheriting the parent's classid on cgroup creation, it doesn't > - * properly propagates config changes in ancestors to their > - * descendents. A child should follow the parent's configuration > - * but be allowed to override it. Fix it and remove the following. > - */ > - .broken_hierarchy = true, > }; Are you sure you want to set the default to false at this point? cheers, daniel