From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Wagner Subject: Re: [PATCH v2 2/3] netcls_cgroup: introduce cgroup_cls_state->is_local Date: Mon, 19 Nov 2012 20:18:35 +0100 Message-ID: <50AA860B.9040804@monom.org> References: <1353123062-23193-1-git-send-email-tj@kernel.org> <1353123062-23193-3-git-send-email-tj@kernel.org> <20121119173026.GJ15971@htj.dyndns.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121119173026.GJ15971-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Tejun Heo Cc: daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org, serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, tgraf-G/eBtMaohhA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Hi Tejun, On 19.11.2012 18:30, Tejun Heo wrote: > cs->is_local will be used to indicate whether the cgroup has its own > configuration or inherited from the parent. It's set when classid is > configured by writing a positive value to cgroup file > "net_cls.classid" and cleared when a negative value is written. > > is_local is visible to userland via cgroup file "net_cls.is_local" so > that userland can know whether a cgroup has its config or not. > > This patch doesn't yet change hierarchy behavior. The next patch will > use is_local to implement proper hierarchy. > > v2: Daniel pointed out that cftype->write_u64() accepts base prefix > (e.g. 0x10 for 16). Updated "%lld" to "%lli". > > Signed-off-by: Tejun Heo > Acked-by: David S. Miller > Acked-by: Neil Horman > Cc: Daniel Wagner Acked-by: Daniel Wagner thanks, daniel