From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gao feng Subject: Re: [PATCH] cgroup_rm_file: don't delete the uncreated files Date: Thu, 06 Dec 2012 14:01:21 +0800 Message-ID: <50C034B1.1090301@cn.fujitsu.com> References: <1354763350-3139-1-git-send-email-gaofeng@cn.fujitsu.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1354763350-3139-1-git-send-email-gaofeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Gao feng Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org on 2012/12/06 11:09, Gao feng wrote: > in cgroup_add_file,when creating files for cgroup, > some of creation may be skipped. So we need to avoid > deleting these uncreated files in cgroup_rm_file, > otherwise the warning msg will be triggered. > > "cgroup_addrm_files: failed to remove memory_pressure_enabled, err=-2" > > Signed-off-by: Gao feng > --- > kernel/cgroup.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index 5cc3724..6928b3e 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -932,6 +932,12 @@ static int cgroup_rm_file(struct cgroup *cgrp, const struct cftype *cft) oops,cft may be NULL,I miss the check of cft in this patch. Please ignore this patch,I will resent it.