From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kamezawa Hiroyuki Subject: Re: [PATCH v2 2/5] memcg: provide root figures from system totals Date: Wed, 06 Mar 2013 19:45:30 +0900 Message-ID: <51371E4A.7090807@jp.fujitsu.com> References: <1362489058-3455-1-git-send-email-glommer@parallels.com> <1362489058-3455-3-git-send-email-glommer@parallels.com> <51368D80.20701@jp.fujitsu.com> <5136FEC2.2050004@parallels.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5136FEC2.2050004-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Glauber Costa Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tejun Heo , Andrew Morton , Michal Hocko , handai.szj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, anton.vorontsov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Johannes Weiner , Mel Gorman (2013/03/06 17:30), Glauber Costa wrote: > On 03/06/2013 04:27 AM, Kamezawa Hiroyuki wrote: >> (2013/03/05 22:10), Glauber Costa wrote: >>> + case _MEMSWAP: { >>> + struct sysinfo i; >>> + si_swapinfo(&i); >>> + >>> + return ((memcg_read_root_rss() + >>> + atomic_long_read(&vm_stat[NR_FILE_PAGES])) << PAGE_SHIFT) + >>> + i.totalswap - i.freeswap; >> >> How swapcache is handled ? ...and How kmem works with this calc ? >> > I am ignoring kmem, because we don't account kmem for the root cgroup > anyway. > > Setting the limit is invalid, and we don't account until the limit is > set. Then it will be 0, always. > > For swapcache, I am hoping that totalswap - freeswap will cover > everything swap related. If you think I am wrong, please enlighten me. > i.totalswap - i.freeswap = # of used swap entries. SwapCache can be rss and used swap entry at the same time. Thanks, -Kame